Comments (2)
apoelstra
commented on July 18, 2024
I think the issue is that our extensions are all Dissat::Unknown and also Input::zero. These combine in the threshold malleability logic from upstream which says that any threshold where not every sub-fragment is Dissat::Unique must be malleable.
(This logic seems wrong to me, btw, at least in the case that k == n, but we'll accept it for now.)
Anyway I think Input::Zero and Dissat::Unknown are logically incompatible ... I think that if we have Input::Zero we should always have Dissat::Unique, and changing this will fix the bug.
Trying to find a smaller test case..
from elements-miniscript.
sanket1729
commented on July 18, 2024
Converting this issue into revisiting all the correctness/malleability properties for extensions.
from elements-miniscript.
Related Issues (20)
- First release HOT 3
- Miniscript fragment to check conditions on signed message HOT 9
- Where's the documentation?
- Introspection HOT 8
- Miniscript MinimalIF bug? HOT 2
- to_string_no_chksum is broken
- wasm-pack: crate-type must be cdylib to compile to wasm HOT 2
- `elements_miniscript::confidential::slip77` duplicates code from `elements::slip77` HOT 3
- Cannot use single "view" blinding key with a descriptor with xpubs HOT 1
- Think about to interpreter API design for checksigfromstack
- `DescriptorType` has wrong `Display` impl for variant `Cov` HOT 1
- `DescriptorType` has wrong `Display` impl for variant `Cov`
- The crate produce very big binary size HOT 2
- base64 feature should enable also elements/base64
- Can this test be uncommented? HOT 1
- Pegin example with pegin address generation from descriptors
- Covenant extension parse example HOT 5
- Covenant extension & "Error: All spend paths must require a signature" error HOT 4
- `to_string_no_chksum` returns debug representation instead of the descriptor string without the checksum? HOT 1
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from elements-miniscript.