Giter Club home page Giter Club logo

Comments (8)

danirabbit avatar danirabbit commented on June 9, 2024

I would think this would be an issue with neon. We should probably just respect .VolumeIcon and let operating systems be responsible for their own branding

from installer.

vjr avatar vjr commented on June 9, 2024

@danrabbit I mean the icon to show during the screen which lists all existing installations. Were you talking about the scenario where pantheon-installer is used to install another distro?

from installer.

danirabbit avatar danirabbit commented on June 9, 2024

Nope, we're talking about the same case. There should be a file called .VolumeIcon on the root of that partition to supply branding.

I think it's not a reasonable scope that we provide branded icons for every possible operating system.

from installer.

vjr avatar vjr commented on June 9, 2024

Oh I see, is there some sort of spec for VolumeIcon? I just placed the PNG file there as .VolumeIcon and it doesn't show in the installer - but yeah - I know this is an early experimental stage. :-)

from installer.

danirabbit avatar danirabbit commented on June 9, 2024

Changed title to reflect :)

from installer.

vjr avatar vjr commented on June 9, 2024

Filed this ticket for KDE Neon https://bugs.kde.org/show_bug.cgi?id=381893 and will submit a PR for the installer here shortly :-)

from installer.

vjr avatar vjr commented on June 9, 2024

The PR is merged but I have a pending question about whether it's enough to just look for .VolumeIcon.png or should I also be looking for .VolumeIcon for which, if so, I can submit another PR.

from installer.

codygarver avatar codygarver commented on June 9, 2024

The original issue here is fixed. If it turns out there's a reason to support more filesnames then a new issued should be opened.

from installer.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.