Comments (8)
I would think this would be an issue with neon. We should probably just respect .VolumeIcon
and let operating systems be responsible for their own branding
from installer.
@danrabbit I mean the icon to show during the screen which lists all existing installations. Were you talking about the scenario where pantheon-installer is used to install another distro?
from installer.
Nope, we're talking about the same case. There should be a file called .VolumeIcon
on the root of that partition to supply branding.
I think it's not a reasonable scope that we provide branded icons for every possible operating system.
from installer.
Oh I see, is there some sort of spec for VolumeIcon? I just placed the PNG file there as .VolumeIcon
and it doesn't show in the installer - but yeah - I know this is an early experimental stage. :-)
from installer.
Changed title to reflect :)
from installer.
Filed this ticket for KDE Neon https://bugs.kde.org/show_bug.cgi?id=381893 and will submit a PR for the installer here shortly :-)
from installer.
The PR is merged but I have a pending question about whether it's enough to just look for .VolumeIcon.png
or should I also be looking for .VolumeIcon
for which, if so, I can submit another PR.
from installer.
The original issue here is fixed. If it turns out there's a reason to support more filesnames then a new issued should be opened.
from installer.
Related Issues (20)
- Feature request: make installer "force" users to encrypt their OS drive HOT 5
- Make EFI ESP optional during custom install HOT 1
- Out of memory crash with gfxmode=auto HOT 1
- Unable to install elementaryOS on Lenovo ThinkPad T430u - Blank screen on boot HOT 1
- SSD TRIM not working on encrypted root partition HOT 1
- Make partition names more descriptive.
- OS7 (stable) install: Custom partition window moved off-screen and could not be dragged back HOT 2
- Custom Partitioning: Erase and install button label is ambiguous
- OS7 (stable) custom partitioning: Several partitions had the same color.
- Show partitioning warnings more obviously
- Window moves when resizing HOT 1
- Use Wayland for installer session
- Partitions legend seems clipped (is actually scrollable) HOT 1
- No partitions visible when running without daemon HOT 1
- Add optional "system hardening" toggle in the installer HOT 4
- Support installer partition styling HOT 3
- Installer doesn't show partitions on MacBook HOT 11
- Custom partitionioning "Decrypt" does not work HOT 2
- Install "duplicity" package by default and let user configure backup in onboarding app
- installation fails due to missing fat32 support HOT 1
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from installer.