Giter Club home page Giter Club logo

Comments (6)

ronmorgen1 avatar ronmorgen1 commented on May 17, 2024

Looks interesting I would be happy to take this. How would you classify a successful deployment?

from elementary.

Maayan-s avatar Maayan-s commented on May 17, 2024

@ronmorgen1

Important background - the CLI has an internal dbt project. This project queries the Elementary tables from the dbt package deployment.
So the flow is:

  1. User installs the dbt package, that collects data to an elementary schema
  2. The CLI has an internal dbt project, with a profile pointing at the elementary schema
  3. The CLI dbt project runs and reads data that should be sent as alerts
  4. The CLI sends alerts to Slack

So a successful deployment means that the elementary schema exists, the CLI can read from it (the profile is well configured), and the CLI can find a Slack config and send a message.

from elementary.

ronmorgen1 avatar ronmorgen1 commented on May 17, 2024

@Maayan-s

I see. So after the CLI installation when the user runs the command edt monitor, a slack message is sent only when tests fail, and now we want to send one when deployment is successful (?)

from elementary.

Maayan-s avatar Maayan-s commented on May 17, 2024

@ronmorgen1

I think we should probably have a --test flag.
The use case here is that you install but don't have any failed tests at the moment, but you still want to make sure the deployment actually works.

from elementary.

github-actions avatar github-actions commented on May 17, 2024

This issue is stale because it has been open for too long with no activity.
If you would like the issue to remain open, please remove the stale label or leave a comment.

from elementary.

elongl avatar elongl commented on May 17, 2024

Added as edr monitor --test.

 --test BOOLEAN                  Whether to send a test message in case there
                                  are no alerts.

from elementary.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.