Does not build on ubuntu about eastl HOT 6 CLOSED

Ah I see the problem we are using a hacked up EAStdC boo. Not as portable as the real one. But these 2 compiler issues are easy to fix. EAThread and others might be a bit harder to get the tests to run. But I think I have a working EASTL lib now locally.

from eastl.

The higher level warnings are because the compiler isn't set into C++11 mode.
The cmake magic required to set all compilers into the correct mode is:
set (CMAKE_CXX_STANDARD 11)

I haven't had a chance to try it yet.

from eastl.

Ah could be for the first one. I just removed the auto. The next one is we have char32 and wchar at the same time.

Scott

On Feb 10, 2016, at 22:21, Rob Parolin [email protected] wrote:

The higher level warnings are because the compiler isn't set into C++11 mode.
The cmake magic required to set all compilers into the correct mode is:
set (CMAKE_CXX_STANDARD 11)

I haven't had a chance to try it yet.

―
Reply to this email directly or view it on GitHub.

from eastl.

I had a go at fixing the compilation errors. Try applying this patch, it appears to work for me. The SetThreadPriority implementation probably isn't ideal but it appears to pass the tests. I haven't tested it on my windows computer yet (currently on holiday), though I doubt I broke anything too badly (Hopefully)

UbuntuCompilationFix.patch.zip

from eastl.

@Draghi I don't know if I can accept patch files because of the CLA requirement by EA legal. Can you please submit a pull request. Cheers.

from eastl.

@rparolin No worries, I've submitted a pull request now.

from eastl.