File version and product version fields are erroneously truncated to 8 bits about rcedit HOT 7 CLOSED

@paulcbetts since you're the one that made the assertion in Squirrel/Squirrel.Windows#545 (comment) that the version fields are 8-bit, is this a 32-bit executable versus 64-bit executable thing?

from rcedit.

Citation Needed? I'm not sure I believe you, but if it's true that'd be rad

from rcedit.

Both 32-bit and 64-bit executables use the same format for these version resources: a 64-bit value containing four 16-bit fields.

I tested this patch using the updated rcedit.exe with a Squirrel build. The Setup.exe file that Squirrel generates is a 32-bit executable, and the patch works fine with it.

from rcedit.

For reference, the code that actually sets these values in rcedit is in rescle.cc lines 215-216 and 241-242. Both are the same code:

root->dwProductVersionMS = v1 << 16 | v2;
root->dwProductVersionLS = v3 << 16 | v4;

The dwProductVersionMS and dwProductVersionLS fields are defined in verrsrc.h:

DWORD   dwProductVersionMS;     /* e.g. 0x00030010 = "3.10" */
DWORD   dwProductVersionLS;     /* e.g. 0x00000031 = "0.31" */

from rcedit.

And here's the MSDN reference while I'm at it. :-)

FILEVERSION version
Binary version number for the file. The version consists of two 32-bit integers, defined by four 16-bit integers. For example, "FILEVERSION 3,10,0,61" is translated into two doublewords: 0x0003000a and 0x0000003d, in that order. Therefore, if version is defined by the DWORD values dw1 and dw2, they need to appear in the FILEVERSION statement as follows: HIWORD(dw1), LOWORD(dw1), HIWORD(dw2), LOWORD(dw2).

PRODUCTVERSION version
Binary version number for the product with which the file is distributed. The version parameter is two 32-bit integers, defined by four 16-bit integers. For more information about version, see the FILEVERSION description.

from rcedit.

Nice!

from rcedit.

Fixed by #7.

from rcedit.