Giter Club home page Giter Club logo

Comments (7)

develar avatar develar commented on August 15, 2024 1

Would it be nice to throw a warning instead

+1 user is able to copy incorrect files by mistake in any case :)

from osx-sign.

malept avatar malept commented on August 15, 2024 1

electron-packager ignores .o files by default as of 8.1.0.

from osx-sign.

develar avatar develar commented on August 15, 2024

electron-builder automatically ignores .o files. I suppose, issue title should be changed to Ignore .o files in node_modules

from osx-sign.

sethlu avatar sethlu commented on August 15, 2024

@develar electron-packager, however, doesn't take .o into account I think? Would it be nice to throw a warning instead so we acknowledge the existence of these troubling files as electron-osx-sign nevertheless walks through every single directory?

from osx-sign.

develar avatar develar commented on August 15, 2024

But I think we should not silently remove it (as we do in case of .cstemp) because it is a user file and we should not do packager tool job.

from osx-sign.

sethlu avatar sethlu commented on August 15, 2024

@develar I agree; I may address this by throwing warnings only... It could be up to the users to resolve these issues for now... .cstemp files are forcefully removed for their being created temporarily during code signing.

from osx-sign.

MarshallOfSound avatar MarshallOfSound commented on August 15, 2024

Closing as per above, packager does this part of the job for us

from osx-sign.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.