Feature request - additional binary files to sign about osx-sign HOT 8 CLOSED

I'll take a look further into this per your note at #4 . I'm not sure if auto-detecting binaries would be the easiest way or if that is possible..? For example - in my app I actually make a call out to a python script which is treated like a binary, but is not really a binary file, it merely needs to be signed with an entitlement to be accepted.

I'll see if I can figure out if there is a way to reliably do it without any user input, or otherwise provide some sensible argument.

from osx-sign.

@jasonhinkle Sounds good. Anyway we could go for the --additional-binaries option without too much work. Also, I'm not sure about a workable delimiter as commas may be used as parts of the paths to any files.
As I'm using substack/minimist to parse the arguments, app as part of the input. We may have all other arguments after the first as additional binaries to be signed:

# To have path/to/my/binary and path/to/my/another/binary.dylib as additional binaries to be signed:
electron-osx-sign my_app.app path/to/my/binary path/to/my/another/binary.dylib
# To have options as well
electron-osx-sign my_app.app path/to/my/binary path/to/my/other/binary [--options...]

Any suggestions on this way of working?

from osx-sign.

I think that would work just fine, it makes sense I think. It probably will be a lesser-used option I'm sure, but as I'm finding electron makes an awesome way to write GUI for command-line applications. That's what I'm doing, ffmpeg in my case I'm able to make simple GUIs to do complicated file conversions.

I haven't had a chance to write any code yet but if you don't get to it then I will once i'm finished with my current project.

from osx-sign.

@jasonhinkle That's fine. I could work on a fork tomorrow on a concatenation of files/dirs along with the required binaries quite quickly.

from osx-sign.

Here it is; it looks like a neat way to work around this issue: https://github.com/sethlu/electron-osx-sign/pull/8

from osx-sign.

I just tested it, there's a minor bug:

Line 114 of index.js:

if (opts.binaries) childPaths.concat(opts.binaries)

should be this:

if (opts.binaries) childPaths = childPaths.concat(opts.binaries)

Once I changed that it worked and signed the additional binaries - awesome!

from osx-sign.

@jasonhinkle cool, thanks! I'll also do some manual testing and that should be ready for merging.

from osx-sign.

Just merged #8. The signing with additional binaries should be available for future releases, which I'm planning to do now, as a lot have been changed since the last.
Again, thanks for helping to improve this module!

from osx-sign.