Comments (9)
With a little more research I figured out how all of the values need to be set in the plist files for the EH and NP helper apps. I posted more info here electron/packager#261 It seems like it's probably more of an issue that should be solved in electron-packager rather than the signing app?
from osx-sign.
Hi @jasonhinkle, I'll say this may depend more on the electron-packager
on which I'm running a pull request here electron/packager#223. I could integrate the automation of CFBundleExecutable and CFBundleIdentifier so it may be easier.
from osx-sign.
I would agree, I think those plist files are really part of the "package" and not really the signing. If you added them to your pull request then it would be even that much better. I currently just have a shell script that is doing the renaming:
APP="My App"
APP_BUNDLE_ID="com.mydomain.myapp"
sed -i "" "s/com\.github\.electron\.helper\.EH/$APP_BUNDLE_ID\.helper\.EH/g" "$FRAMEWORKS_PATH/$APP Helper EH.app/Contents/Info.plist"
sed -i "" "s/Electron Helper/$APP Helper/g" "$FRAMEWORKS_PATH/$APP Helper EH.app/Contents/Info.plist"
sed -i "" "s/com\.github\.electron\.helper\.NP/$APP_BUNDLE_ID\.helper\.NP/g" "$FRAMEWORKS_PATH/$APP Helper NP.app/Contents/Info.plist"
sed -i "" "s/Electron Helper/$APP Helper/g" "$FRAMEWORKS_PATH/$APP Helper NP.app/Contents/Info.plist"
from osx-sign.
Hi @jasonhinkle, I've already added in the lines to automatically rename the helper EH/NP apps along the other files. One thing to note is that after renaming any files, or editing any plists, do re-codesign the application package to avoid unsigned parts.
from osx-sign.
Awesome! One thing though is that the BundleId seems to be "com.mydomain.myapp.helper" for all three of the helpers. I'm not sure if this matters or not? For my submission the EH one the id is "com.mydomain.myapp.helper.EH" and the NP one is "com.mydomain.myapp.helper.NP"
My app is pending review right now so I can't submit another binary to test it. But, I do know that it worked with those IDs.
(Sorry this is here instead of your electron-packager build - we can move discussion there if you prefer)
from osx-sign.
@jasonhinkle I think for each of the helper apps Helper
, Helper EH
and Helper NP
should have a different CFBundleIdentifier
like what you mentioned.
I still have an app with review pending. After getting something from iTunes Connect may I know where to fix with this codesign
wrapper I guess.
from osx-sign.
That sounds great. I'll keep testing away too. Thanks for building these two tools, without your pull request and this signing app I don't think I would have been able to get my app built correctly. I'm sending more feature requests your way - if you like any of these ideas but want some help, let me know and I can probably find some time to code and submit pull requests.
from osx-sign.
@jasonhinkle I could plan to work on #5 as it is a quick fix for productbuild
. As for #6, personally never having packed any binaries into Electron yet, I think running a deep search in the directory and sign every binary file may work easier than specifying individual binaries as parameters?
We could continue having the discussion in the feature requests so to lay out everything neatly.
from osx-sign.
@jasonhinkle @sethlu Hi, I'm having this issue too onmyway133/notes#541
How did you solve this?
from osx-sign.
Related Issues (20)
- It clones signing options for every file it signs HOT 4
- Sandbox entitlement leads to crash at launch HOT 2
- "Unidentified developer" when opening universal app HOT 12
- Unsigned library dependencies HOT 1
- Latest release (1.0.2) is broken: [FAILED] Cannot find module './sign' (ships only index.js, eg. sign.js is missing) HOT 4
- Electron-Fast Api App not working after signing HOT 1
- Bypass spctl check?
- Running electron-oxs-sign on MacBook Air (M2) prevent python from working thereafter HOT 2
- Cannot push to Appstore Connect
- Asset validation failed (90266) Install folder failed HOT 1
- Mac App Store refuses app via transporter HOT 11
- Signing fails in Yarn PnP environments HOT 3
- invalid destination for symbolic link in bundle HOT 1
- Hello world
- preAutoEntitlements are applied to wrong files (inherit files) and breaks Mac App Store build HOT 1
- Signed app crashing on arm64 HOT 1
- Default `embedded.provisionprofile` doesn't used in `signApplication` HOT 2
- Codesign all files in one step
- `codesign` randomly hangs forever when building the app HOT 4
- MAS build crashes right before mainWindow gets visible: GPU not usable HOT 4
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from osx-sign.