Comments (4)
We've avoided the jQuery style ambiguous getter/setter throughout the Atom
codebase, for various reasons:
- It complicates the implementation of getters and setters by making the
same function serve two roles - It consumes the most likely name you would want to use for the actual
property being set. If I want to have a@badge
instance variable, I can't
because there's already a method namedbadge
.
On Tue, Aug 6, 2013 at 11:30 AM, David Graham [email protected]:
Getters and setters are uncommon in JavaScript. Instead of setBadge and
getBadge, can we have a badge() method that does this?badge: (text) ->
if text
# set the text
return theBadgeText()sets the badgedock.badge('42')
gets the badgetext = dock.badge()
—
Reply to this email directly or view it on GitHubhttps://github.com//issues/46#issuecomment-22200340
.
from electron.
See https://github.com/atom/atom-shell/wiki/app#appdockbouncetype for the new dock API.
from electron.
Getters and setters are uncommon in JavaScript. Instead of setBadge and getBadge, can we have a badge() method that does this?
badge: (text) ->
if text
# set the text
return theBadgeText()
# sets the badge
dock.badge('42')
# gets the badge
text = dock.badge()
from electron.
We've never adopted the jquery one-function-as-getter-and-setter style in
Atom. We may be breaking JavaScript patterns, but I'd rather keep new API
methods consistent with the old ones. But if you think that is crazy feel
free to school @github/atom.
from electron.
Related Issues (20)
- [Bug]: node_modules/electron/dist/electron exited with signal SIGSEGV HOT 1
- [Bug]: Clicking on the color picker doesn't do anything HOT 4
- [Bug]: New Protocol.handle vs Protocol.registerFileProtocol does not fetch files properly.
- [Bug]: Crash base::subtle::RefCountedBase::ReleaseImpl() EXCEPTION_ACCESS_VIOLATION_READ HOT 1
- [Bug]: Capturing the screen is broken in the newer version (desktopCapturer) HOT 2
- gitHub.com/docker/repo
- [Feature Request]: add config.hideDock to BrowserWindow.setHiddenInMissionControl
- [Bug]: Calling session.defaultSession.webRequest.onHeadersReceived after ready and before window creation causes silent crash
- webContents.getPrintersAsync() not returning printer list on Linux Mint Cinnamon 19.1 HOT 3
- [Bug]: Frameless BrowserView.setAutoResize() is broken in v30.0.1
- [Infra]: Test check CI failed to execute because of npm package not found HOT 3
- [Bug]: <input type="file"> is not showing dialog on click HOT 7
- [Bug]: app.setLoginItemSettings({ openAtLogin: true }) doesnt work in APPX after publishing it.
- [Bug]: <input type=file> not working in WebContentsView HOT 1
- [Bug]: Occasional segfault when closing window on Linux
- stop removing tags from your repo HOT 12
- [Bug]: `screen.getAllDisplays()` and `desktopCapturer.getSources()` order no longer matches (29.3.2, 30.0.2)
- [Bug]: `desktopCapturer` thumbnails not respecting `thumbnailSize`, always low-res (29.3.2)
- [Bug]: Calling preventDefault on BrowserWindow close event still destroys BrowserViews' webContents
- [Feature Request]: Support webp format in NativeImage class [totoWEBP()]
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from electron.