Giter Club home page Giter Club logo

Comments (6)

codebytere avatar codebytere commented on July 20, 2024 3

Closing in light of above comment.

from chromedriver.

andrevmatos avatar andrevmatos commented on July 20, 2024 1

@ghisvail You may use ELECTRON_CACHE env var without patching the file (as per npm/electron-download package. I got this working for my electron flatpak:

            ...
            "build-options": {
                "env": {
                    "ELECTRON_CACHE": "/run/build/rocketchat-desktop/npm-cache"
                }
            },
            "sources": [
                "generated-sources.json",
                ...
                {
                    "type": "file",
                    "url": "https://github.com/electron/electron/releases/download/v2.0.0/chromedriver-v2.0.0-linux-x64.zip",
                    "sha256": "a57f4c534bbeee806912f2b25651ef7dd3b38b5a0d7b1c6e3920f9db0dc4319b",
                    "dest-filename": "chromedriver-v2.0.0-linux-x64.zip",
                    "dest": "npm-cache"
                },
                {
                    "type": "file",
                    "url": "https://github.com/electron/electron/releases/download/v2.0.0/SHASUMS256.txt",
                    "sha256": "4d7edbfa504e1dc45ea92b02baafe7125e9f4892a98f3e6ec53fa97ec9acf8c2",
                    "dest-filename": "SHASUMS256.txt-2.0.0",
                    "dest": "npm-cache"
                }
...

from chromedriver.

ghisvail avatar ghisvail commented on July 20, 2024

Any ideas?

from chromedriver.

ghisvail avatar ghisvail commented on July 20, 2024

Right now, a working solution consists in patching download-chromedriver.js to inject the offline cache location to electronDownload.

It sounds to me like the sort of things that could be addressed by an environment variable. Thoughts?

from chromedriver.

Arxcis avatar Arxcis commented on July 20, 2024

@ghisvail I have a similar issue like you had here. I would like to apply a patch like you did, but I have no idea of how to create a .patch file like that. Would you be so kind and point me in the right direction? I have a related issue here flatpak/flatpak-builder-tools#103

Using the ELECTRON_CACHE envvar did not work for me.

from chromedriver.

refi64 avatar refi64 commented on July 20, 2024

I think the move to @electron/get might have broken this? I don't see ELECTRON_CACHE being read anywhere anymore.

from chromedriver.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.