Giter Club home page Giter Club logo

Comments (2)

AltamiroAJ avatar AltamiroAJ commented on August 12, 2024 1

I opted to use the original dimensional equations in the imperial system, since that way it would be easy to look at the equations and directly compare them to the original paper as they were written.

This was exactly what I was thinking, but I asked because I want to keep the code consistency as much as possible.
Thanks for the response

from python-openplaning.

elcf avatar elcf commented on August 12, 2024

Hi, good question, particularly since some of the empirical equations have units mixed into their constants. OpenPlaning right now assumes inputs with the metric system. Some equations you'll notice are unchanged simply because those equations are non-dimensional (so the unit system bookkeeping is already taken cared of by consistently using the metric system). One example that uses dimensional equations is the get_seaway_behavior function. There, I just converted the metric system input to imperial, and then converted the imperial results back to metric (you can see the conversions in lines 872-880 and 994). I opted to use the original dimensional equations in the imperial system, since that way it would be easy to look at the equations and directly compare them to the original paper as they were written.

from python-openplaning.

Related Issues (2)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.