Giter Club home page Giter Club logo

Comments (4)

doubret avatar doubret commented on July 30, 2024

You can translate it into a (match_all) filter.
Idem for x => false (not(match_all)).

There are also the cases (x => some conition && true) or (x => some conition && false) (idem with ||). In this case it could be temptating to simplify the filters (some condition && false will always be false...) but i'm not sure it's a good idea because it will mess the score. The match_all aproach seems to be more robust.

from elasticlinq.

damieng avatar damieng commented on July 30, 2024

The plan is to optimize them out of the criteria as you mentioned in your second option. I can't see how it would affect the score as these optimizations are only if they evaluate entirely locally - i.e. have no reference to product.

from elasticlinq.

doubret avatar doubret commented on July 30, 2024

As you can associate a score boost to a query and later filter by score, removing a query that boosts the score will change the results.
Let's take this :
{
"query": {
"bool": {
"should": [
{
"term": {
"prop": 123
}
},
{
"match_all": {}
}
],
"boost": 2
}
}
}

As you can see, the query will return all the documents but with score boosting. In c# it could write something like this :
.Query(x => (x.prop == 123 || true), boost: 2)
In this case, removing the criteria has an effect.

If you don't plan to support scoring it's maybe not a problem to remove the filters though.

from elasticlinq.

doubret avatar doubret commented on July 30, 2024

For exemple :

This query returns some documents :
{
"min_score": 1.4,
"query": {
"bool": {
"should": [
{
"term": {
"Int": 2
}
},
{
"match_all": {}
}
]
}
}
}

But this one returns nothing :
{
"min_score": 1.4
}

from elasticlinq.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.