Comments (4)
This PR updates the EUI EuiGlobalStyles
to support using partial global styles. There will be an additional small PR to add the update to the EUI+ theme but any further EUI+ specific changes will be done in the design update tasks, e.g. for updating the typography in #7795
from eui.
I'm generally not a huge fan of adding functionality to production components for the sake of non-production use-cases. Can I ask why we can't just disable EUI's global styles completely via <EuiProvider globalStyles={false} />
and then just manually import or copy/paste the styles we do want to Docusaurus? That would personally by my preference (putting logic/customization in the lower stakes repo).
from eui.
The idea was to be able to reuse some of the things where needed by making this more flexible. But I can agree that:
- it makes sense to setup things project independent (though the idea in EUI+ is to reuse as much as possible and the theme is opinionated)
- the EUI+ usage would be a one-off so far and we don't fully know yet what exactly will be used and how down the line as we only just start implementing
I think we could work also with globalStyles={false}
for now and see later in the process how useful the granular update of EuiGlobalStyles
will be and decide then if we want to move forward with this? cc @tkajtoch
from eui.
The second bullet point is definitely my concern! I think I just also don't want to spend too much time reviewing/working on future-proof logic on source code when we don't have clear production usages in mind. Hope that makes sense!
from eui.
Related Issues (20)
- EuiSteps unordered variant HOT 6
- [EuiSelectableTemplateSitewide] Allow default a link behavior for results HOT 3
- [EuiTabs ][A11Y] - Using `EuiBetaBadge` within `EuiTab` HOT 3
- Spike: Explore switching to Yarn Berry
- [New docs] Implement typography design changes
- [EuiComboBox] support for append and prepend on group labels
- setEuiDevProviderWarning to accept an optional callback function
- [EuiDataGrid] Ensure gridStyles updates trigger a cell height recalculation
- [EuiAvatar] Calculate high-contrast text against background HOT 3
- [EuiDataGrid] Cell filtering UX unusable after scroll HOT 13
- [Docs] EuiProvider custom breakpoints example no longer works HOT 1
- Datagrid - Rearranging visible columns works on the grid but does not hold state on drop down menu.
- [EuiIcon] Update the `logoElasticStack` icon to latest
- [DataGrid] Enable `Auto Fit` behavior when `Cell row height` - `Custom` is selected HOT 2
- [EuiComboBox] Add autocomplete="off"
- [New docs] Implement documentation content page design changes
- Error when trying to use EUI with Observable Framework HOT 2
- [New docs] Add interactive Demo component
- EUI Icons not rendering for some users HOT 5
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from eui.