Comments (5)
@MichaelMarcialis how do you feel about keeping the slight blue tint/halo around the border in active/focus state? i.e.,
I personally kind of like it for greater visibility. WDYT?
from eui.
This is not a strict objection, just adding some food for thought.
If we add this as an optional property, do we lose some important consistency? Users may have established a recognition of the grab
handle meaning that things can be resized. Do we lose that by allowing this option?
Likewise, if we do add this option, what is the guidance that we provide that goes along with this? When should we be using the minimal option vs the regular option.
from eui.
If we add this as an optional property, do we lose some important consistency?
Discover has already their own resize UI overriding/hiding the grab handle, so this is basically just bringing EUI to parity with production 🤷
Likewise, if we do add this option, what is the guidance that we provide that goes along with this? When should we be using the minimal option vs the regular option.
++, agreed some firmer guidance on this would be nice. My best guess is to opt out of the drag handle when there's a lot of other busy things going on on the page, or the resize behavior is "nice to have" but not a primary focus.
from eui.
@JasonStoltz, @cee-chen: My apologies for the late reply to your comments. Some quick responses below:
If we add this as an optional property, do we lose some important consistency? Users may have established a recognition of the grab handle meaning that things can be resized. Do we lose that by allowing this option?
Discover has already their own resize UI overriding/hiding the grab handle, so this is basically just bringing EUI to parity with production 🤷
I don't disagree with you that this has the potential to create some level of inconsistency, where some instances of a EuiResizableButton
are using the faux icon approach and others are using this new border approach. That said, I've personally struggled and ultimately ended up disliking ever having to use the EuiResizableContainer
because there was no alternative to the current faux icon approach. When having to work within tight spaces and/or in close proximity to very robust interfaces, having to accommodate for the appearance of that icon can prove very troublesome. I imagine I'm not the only designer to feel that pain. A perfect example is the resizable button that appears at the bottom of the unified search interface (where its appearance almost looks like a visual bug).
That said, there are probably some instances in Kibana where the current faux icon approach is perfectly acceptable and perhaps even desirable. If that assumption is right, then I think keeping it as the default makes sense despite the consistency concerns (for the sake of avoiding breaking or unwanted changes). However, if that assumption is incorrect, I'd be open to a conversation to replace the faux icon approach altogether.
Likewise, if we do add this option, what is the guidance that we provide that goes along with this? When should we be using the minimal option vs the regular option.
++, agreed some firmer guidance on this would be nice. My best guess is to opt out of the drag handle when there's a lot of other busy things going on on the page, or the resize behavior is "nice to have" but not a primary focus.
@cee-chen's guidance is pretty much exactly what I had in mind. If the experience doesn't demand resizing as an imperative, and the resizable button placement is in tight quarters or in close proximity to an already busy interface, then perhaps this option may make more sense.
I suppose if we wanted to get more granular with it, we could also add more specific guidance such as "both ends of the border version must either 1) touch another border on the opposing axis in your interface or 2) touch the edge of the viewport (to avoid cases of resizable borders floating in space)", but I'm not sure if we require that level of hand-holding.
from eui.
That makes sense to me @MichaelMarcialis, thank you for the detailed reply.
from eui.
Related Issues (20)
- [EuiIcon] Icon asset paths/content off center from viewbox HOT 8
- [EuiSuperDatePicker] Allow setting absolute dates without Enter key HOT 1
- [New docs] Implement basic design changes to match the custom theme
- [EuiTooltip][KEYBOARD]: Would we consider adding `ESC` keypress to dismiss the tooltip?
- [EuiRange] Ticks not displaying correctly in React Strict Mode HOT 2
- [EuiSelectable] Screen reader arrow navigation experience is broken on Safari+VO HOT 1
- [Meta] [New docs] Full-text search
- [Meta] [New docs] Publish Elastic Design System patterns
- [EuiInputPopover] Removed setTimeout causes flaky test behavior HOT 1
- [EuiDualRange] Upper value isn't allowed to be blank HOT 3
- [EuiPageTemplate] Account for new serverless header style HOT 5
- [EuiDataGrid] Grid grows to infinite height in flex container if `height` not provided
- [EuiFlex] Add missing props to `EuiFlexGroup` and `EuiFlexItem`
- [Meta] Support React Strict Mode
- EuiPortal should be able to use different portal target than document.body based on provided Context HOT 7
- [EuiDataGrid] Cell text content visible below truncation when using `fontSize: "s"`
- FlexItem does not accept HTMLAttributes like title anymore HOT 1
- EuiSteps unordered variant HOT 1
- [EuiSelectableTemplateSitewide] Allow default a link behavior for results
- [EuiTabs ][A11Y] - Using `EuiBetaBadge` within `EuiTab`
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from eui.