Allow Relative Path Urls about elasticsearch-js HOT 8 CLOSED

While allowing relative paths in the browser certainly makes sense, it would be broken by the cluster discovery functionality. Maybe you should try this approach instead:

angular.module('components.search')
  .service('es', function (esFactory) {
    return esFactory({
      host: window.location.protocol + '//' + window.location.host + '/services/elastic'
    });
  });

from elasticsearch-js.

Well, that doesn't allow us to use grunt-connect-proxy (https://github.com/drewzboto/grunt-connect-proxy). Grunt connect proxy is specifically looking for relative path requests made through $http which it then reroutes through grunt (node) server side to the actual web server configured in grunt.

Your suggestion is causing http requests to http://localhost/services/elastic instead of http://localhost:9000/services/elastic. I'll try a couple other things and report what's happening while I debug through the code.

from elasticsearch-js.

As far as I know we're using this library to just query elastic search (http://elasticsearch.github.io/elasticsearch-js/api.html#search). Perhaps we can just use raw $http requests with the elastic dsl in the http request body.

from elasticsearch-js.

That's a fair observation. If you are only doing search queries, and your entire cluster is behind a load balancer, then using elasticsearch.js in the browser is probably overkill.

from elasticsearch-js.

Not sure why I didn't think about this earlier, but you do something like this:

return esFactory({
  host: {
    host: '',
    port: '',
    path: '/services/elastic'
  }
});

right now this will cause the requests to go to http:///services/elastic but it should go to /services/elastic. I'll get that bug patched

from elasticsearch-js.

Nice, great thinking @spenceralger.

from elasticsearch-js.

@DeanPoulin Just updated the master build, if you want to give it a shot. Check out the unit tests for an example.

from elasticsearch-js.

@spenceralger thanks for your help, I'll give it a spin and let you know how it goes. Much appreciated.

from elasticsearch-js.