Giter Club home page Giter Club logo

Comments (4)

MaineC avatar MaineC commented on August 22, 2024

+1 from my side to keep documentation examples under build and test cycles.

Not sure if we should first take a step back maybe and review what we want to accomplish.

Here's my gist after updating the docs for the Java API query dsl examples:

What we have at the moment is the following:

https://www.elastic.co/guide/en/elasticsearch/client/java-api/current/bool.html

IMHO on the one hand this is not enough as for most queries it doesn't cover all options, so no real reference documentation there. It duplicates documentation as well as what is written there to some part is written in JavaDoc already. On top it's never built so easily forgotten when ppl change the API.

Another approach I've seen in the wild:

https://github.com/randomizedtesting/randomizedtesting/tree/master/examples/maven/src/main/java/com/carrotsearch/examples/randomizedrunner

To me those are complimentary to the reference style docs JavaDoc typically provides: It's giving real world examples centred around some topics. On top it has the advantage of being under build and test cycles.

Lastly there's the Lucene JavaDoc only approach:

https://lucene.apache.org/core/4_1_0/core/index.html?overview-summary.html

Close to the code, examples still not under build and test cycles.

Me personally if I was a user I would love to see the second type of docs - could be as real code examples in some test package. If it's done using the style @dadoonet outlined above it would be better in line with the rest of our documentation - great as well. For such documentation I personally find it frustrating if there are errors in the docs, so to me it would be really important to keep them under build and test cycles.

In addition I would wish for detailed reference docs in our JavaDocs, potentially linked from the examples above.

from docs.

ppf2 avatar ppf2 commented on August 22, 2024

It basically means that when a developer changes whatever part of code, the documentation is automatically updated with the new content.

+1 and will help our doc from becoming stale over time :)

from docs.

dadoonet avatar dadoonet commented on August 22, 2024

Hmmm. Just found this doc today: http://mrhaki.blogspot.fr/2014/04/awesome-asciidoc-include-partial-parts.html

May be this is something we can use easily? I'm going to give it a try.

from docs.

dadoonet avatar dadoonet commented on August 22, 2024

Closed by elastic/elasticsearch#24354. Thanks to @nik9000 !

from docs.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.