Rename GetProcessors to Processors in registry about apm-server HOT 6 CLOSED

+1 on following to conventions (most of the time ;-) ). Feel free to open a PR with the change, then also the rest of the team can get involved in reviewing it.

from apm-server.

I'd appreciate to see this changed, looking forward to the PR.

from apm-server.

I also prefer to avoid java-ish Get* / Set* / New* lingo 👍

from apm-server.

For me it doesn't matter too much if we call it GetProcessors or Processors. Both works. Let's see what the rest of the team thinks.

For the empty registry functions: HereI think it's important that we keep it as I could see additional logic in it in the future so if we add any, we don't have to change the rest of the code. Also it allows us to keep the variables private. But I'm aware this is personal preference :-)

from apm-server.

Yes,this might not be a breaking change.But as the project is in its initial phases if we follow go conventions it helps in thinking in terms of go idioms and will help future design as well.

from apm-server.

@ruflin kool.

from apm-server.