Remove `root.span` from the span payload about apm-agent-ruby HOT 8 CLOSED

I get it. Sounds like a good point. Not sure how removing it will affect everything else. I'll look into it 👍

from apm-agent-ruby.

Closing as these aren't actually root spans in the original sense.

from apm-agent-ruby.

So there's no span covering the entire transaction?

from apm-agent-ruby.

@mikker Exactly - also just noticed that the description was wrong, fixed that now.

from apm-agent-ruby.

👍

from apm-agent-ruby.

This isn't actually a root span as much as it is how Rails works. So the only way to remove that one giant span is to avoid instrumenting controller actions which I don't think we want.

Depending on how much you want to get rid of that bar I'm not sure it's the right choice to remove it?

from apm-agent-ruby.

I'll experiment a bit. But it seems like a weird choice.

from apm-agent-ruby.

The reason we've opted to not show it in the UI is because it's superfluous, also never carries any detail information. The length of the root span is the same as the transaction itself (which is clearly indicated in the x-axis), while most other spans will carry detail information and be more interesting to look at. It just nags us/me that we leave space for something that's clear repeated. But then again, my knowledge on the instrumentation and how Rails should show up is very sparse - so I'd leave it if you feel strongly about keeping it in. It's just the only agent that does it compared to Node, Python and JS.

from apm-agent-ruby.