Comments (2)
Not everything is for Lifting
: Class
and (:=>)
are huge orphan magnets as well, and were originally only implemented for base
instances, but the core libraries generally can't incur any new dependencies like this going the other way around.
I'm rather inclined to leave things together, as I intend to go through and properly add the missing Class
and (:=>)
instances for the packages this package depends on. (I should have done so long ago, but haven't had the energy to tackle it.)
In a split story those instances would be forced to be orphans, and I pretty flatly refuse to maintain packages full of orphans as they induce terrible failure modes for users.
This is aside from pragmatic concern that I get a lot of 'please lift out this particular small core or that one out of package XYZ' requests at the same time a I get requests to add instances for X Y or Z that would otherwise be orphaned. These requests can rarely agree on what the small core should be. The problem with them is their net effect is to pretty much render my life as a maintainer a living hell, as I often have to deal with release cascades of 40+ package releases when I move content between packages that sit under a bunch of others like this. If at any point we cleave wrongly and I have to move stuff between the two packages later, that can eat a week at a time and increase trustee work.
Given the "new" dependencies here are all actually core libraries except hashable
, which is all but morally one, and transformers-compat
-- which sees wide adoption for patching over the incompatible changes we get in transformers
-- and the orphan instance issue for said core libraries I'm going to lean towards not doing this at this time.
I'm far more inclined in the medium-to-long term to see about getting the core Data.Constraint
module into base
, (possibly modulo Class and (:=>), depending on standardization woes) but the story of how to juggle where the instances wind up while avoiding orphans is a rather headache inducing affair on the best day. It'd be a slightly more desirable state to reach as it'd let us simultaneously extend things correctly to all the core libraries, but the transition/coordination pain to get there is something I'm not in a hurry to endure, and would last multiple years. I'm already living through it in miniature with the migration of Semigroup
into base
, and that is far, far less exotic!
Tentatively closing this to signal intent.
from constraints.
I appreciate the explanation. That makes a lot of sense (especially the orphan problem). Fortunately, I no longer even need such a constraints-core
.
from constraints.
Related Issues (20)
- Expose ComposeC
- divideTimes' constraint is too tight
- Class instances HOT 4
- Update for QuantifiedConstraints
- Divides a b :- (Mod b a ~ 0) HOT 3
- instance Lift (Dict cls) HOT 2
- Consider using AppendSymbol in Data.Constraint.Symbol HOT 3
- constraints-0.10.1 needs revision HOT 1
- An adjunction(?)
- constraints-0.11 and 0.11.1 need base < 4.16 revisions HOT 1
- Update for GHC 9.2 HOT 2
- Build failure with `mtl-2.3` HOT 1
- The `forall` function triggers `-Wforall-identifier` on GHC 9.4
- Use `withDict` instead of `unsafeCoerce` to implement `magic`
- Build failures with mtl-2.3 and `transformers < 0.6` HOT 2
- Add Data.Constraints.Char for GHCs where it is available. HOT 3
- constraints-0.13.1 cannot be build with GHC 9.4 HOT 1
- Soundness of `powMonotone2` HOT 1
- constraints-0.13.4 cannot be built with GHC 9.10 alpha 1 HOT 1
- Data.Constraint.Nat Log2 functions HOT 3
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from constraints.