Giter Club home page Giter Club logo

Comments (6)

howarddo2208 avatar howarddo2208 commented on August 28, 2024 2

now you fixed the issue by hard-code the text color, but then the light theme on all sites is unreadable @EINDEX.
image
Please consider my PR #26 . Btw, I tested the tailwind, it never switches to dark tho, so I think all the dark: styles are not used.

from logseq-copilot.

EINDEX avatar EINDEX commented on August 28, 2024 2

@howarddo2208 your solutions are awesome, thanks.

from logseq-copilot.

EINDEX avatar EINDEX commented on August 28, 2024 1

Sorry those days were busy with work, you have to set env var before build.

@howarddo2208

export VERSION=v0.0.0

from logseq-copilot.

howarddo2208 avatar howarddo2208 commented on August 28, 2024

I suspect the tailwind doesn't recognize theme change, but upon trying to fiddle with the code, I ran to an issue with the build script. Do you know how to resolve this @EINDEX ?

> [email protected] build
> node build.mjs

/Users/tanhopdo/Developments/opensource/logseq-copilot/src/manifest.json.cjs:28
    version: process.env.VERSION.replace('v', ''),
                                 ^

TypeError: Cannot read properties of undefined (reading 'replace')
    at build (/Users/tanhopdo/Developments/opensource/logseq-copilot/src/manifest.json.cjs:28:34)
    at build (file:///Users/tanhopdo/Developments/opensource/logseq-copilot/build.mjs:96:20)

Node.js v18.16.0

from logseq-copilot.

EINDEX avatar EINDEX commented on August 28, 2024

I force the font color for dark and light modes, which will suit for system's default theme.
If change theme at search engine, may can not using the correct theme.

Will keep this open until copilot can support theme by sites.

from logseq-copilot.

howarddo2208 avatar howarddo2208 commented on August 28, 2024

Yeah, it doesn't update based on the site. But turns out the problem is actually from the body style, other search sites update the body {color} when changing the theme and the extension inherit it, but it is not the case for duckduckgo

from logseq-copilot.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.