(.. | numbers) += 1 fails with: "left hand side must be FieldAccess" about jackson-jq HOT 7 CLOSED

Any ideas why this might be happening? I'd be willing to help create a fix if I could get some pointers. Thanks!

from jackson-jq.

@btiernay I'm sorry to have kept you waiting, I'll try to look closely into the problem this weekend.

from jackson-jq.

Sorry for my late response, I'm currently working on a fix.

The problem was that we cannot determine which part of an input JsonNode to update because in the current implementation we only handled a simple FieldAccess like .a[0].a in assignments.

In btiernay's example, we have an input {"x": 1} and (..|numbers) evaluates to 1. Then we apply += 1 against 1 and get 2. But where in {"x": 1} we should put this 2 back, we do not know now.

I'm trying to fix this by creating a simple wrapper around JsonNode and wrapping an input before evaluating assignment expressions. So far (..|numbers) += 1 worked, but test cases (such as jq '.[1] = 1' <<< '[]', in which a non-existent element of an input array or object is accessed) started to fail and still working on a fix.

from jackson-jq.

Thanks for your support, much appreciated!

from jackson-jq.

I am facing a similar issue. Do we have a solution for this? My rule works fine in jqplay but I get this error in java.
net.thisptr.jackson.jq.exception.IllegalJsonArgumentException: left hand side must be FieldAccess
at net.thisptr.jackson.jq.internal.tree.binaryop.assignment.UpdateAssignment.apply(UpdateAssignment.java:28)
at net.thisptr.jackson.jq.internal.tree.PipedQuery.applyRecursive(PipedQuery.java:42)
at net.thisptr.jackson.jq.internal.tree.PipedQuery.apply(PipedQuery.java:25)
at net.thisptr.jackson.jq.internal.IsolatedScopeQuery.apply(IsolatedScopeQuery.java:21)
at net.thisptr.jackson.jq.JsonQuery.apply(JsonQuery.java:20)

from jackson-jq.

It worked for me by making this change in the rule
(. |= (. + if has("dataSource") then {("newDataSource"): .dataSource} else . end)) | del(.dataSource)
New rule:
(. + if has("dataSource") then {("newDataSource"): .dataSource} else . end) | del(.dataSource)

from jackson-jq.

This long-standing issue has been resolved in 1.0.0-preview.* versions.

from jackson-jq.