Parsed version of server_protocol about ewf HOT 7 OPEN

If we know for sure that this protocol version will be used
then we should make the attribute attached

otherwise we can make it a function instead of an attribute
If this is likely to be called many time, then we can always compute on demand and store in internal attribute.

-- Jocelyn

from ewf.

I don't think we can make it attached, as req.server_protocol isn't guaranteed to have sensible content, is is? For instance, an HTTP/0.9 client, or a telnet client. Or does the connector guarantee otherwise when a WSF_REQUEST is created? Has a 400 (or something) response been issued already?

from ewf.

I see .. and no, I don't think the connector does anything for that.
maybe apache does it itself.
but nino don't but we could fix that as well.

from ewf.

then ... maybe we could have that as precondition ...
Or we just make it detachable as you suggested
or keep it attached, but carrying a boolean is_valid: BOOLEAN ...
but I don't feel it good with that.

Probably we could require that at the WSF level
that is to say

WSF_REQUEST.make_from_wgi (r: WGI_REQUEST; vers: HTTP_PROTOCOL_VERSION)
do ... end

and this would be computed and checked in
WSF_TO_WGI_SERVICE.execute (..)

from ewf.

I like that last suggestion.

from ewf.

For now we could still add a class
WSF_HTTP_PROTOCOL_VERSION

that would take as input the server_protocol
and have a is_valid: BOOLEAN

if server_protocol does not carry any information
we could have a default being 1.1

anyway, if such class exist in EWF .. user can start using it, instead of redoing the parsing them self
then later we can decide how to integrate it nicely with WSF_REQUEST

from ewf.

I'll add the class then, and we can decide how to use it later.

from ewf.