Comments (7)
If we know for sure that this protocol version will be used
then we should make the attribute attached
otherwise we can make it a function instead of an attribute
If this is likely to be called many time, then we can always compute on demand and store in internal attribute.
-- Jocelyn
from ewf.
I don't think we can make it attached, as req.server_protocol isn't guaranteed to have sensible content, is is? For instance, an HTTP/0.9 client, or a telnet client. Or does the connector guarantee otherwise when a WSF_REQUEST is created? Has a 400 (or something) response been issued already?
from ewf.
I see .. and no, I don't think the connector does anything for that.
maybe apache does it itself.
but nino don't but we could fix that as well.
from ewf.
then ... maybe we could have that as precondition ...
Or we just make it detachable as you suggested
or keep it attached, but carrying a boolean is_valid: BOOLEAN ...
but I don't feel it good with that.
Probably we could require that at the WSF level
that is to say
WSF_REQUEST.make_from_wgi (r: WGI_REQUEST; vers: HTTP_PROTOCOL_VERSION)
do ... end
and this would be computed and checked in
WSF_TO_WGI_SERVICE.execute (..)
from ewf.
I like that last suggestion.
from ewf.
For now we could still add a class
WSF_HTTP_PROTOCOL_VERSION
that would take as input the server_protocol
and have a is_valid: BOOLEAN
if server_protocol does not carry any information
we could have a default being 1.1
anyway, if such class exist in EWF .. user can start using it, instead of redoing the parsing them self
then later we can decide how to integrate it nicely with WSF_REQUEST
from ewf.
I'll add the class then, and we can decide how to use it later.
from ewf.
Related Issues (20)
- WebSocket Client HOT 1
- WebSocket Test HOT 1
- / as part of the value of a URI template variable results in handler not being found HOT 6
- WSF_REQUEST.percent_encoded_path_info does not work HOT 8
- WSF_REQUEST.save_uploaded_file: unsafe
- WSF_POST_HELPER does not support non-RESTful POSTs HOT 2
- gewf and autodetect which connector to use
- Consistency of Not Modified responses in WSF_METHOD_HELPER HOT 1
- Policy-driven framework should reject PUT requests that contain a Content-Range header HOT 1
- Add a last_modified routine to WSF_SKELETON_HANDLER HOT 1
- WSF_TRACE_RESPONSE does not include Content-Type header HOT 1
- Possible replacement for code 301 Moved permanently
- Use of 411 Length required response code HOT 2
- CORS headers for policy-driven framework HOT 2
- VARY header set to application/json rather than accept HOT 1
- Documentation error in {WSF_SKELETON_HANDLER}.check_request
- WSF_REQUEST.cookies_table does not terminate on cookies without a value. HOT 2
- Issues are WSF_RESPONSE.status_code/status_is_set
- Segmentation Fault on map_uri_template_agent_with_request_methods HOT 4
- JSON_PARSER.parse_string can exhaust memory HOT 2
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from ewf.