Giter Club home page Giter Club logo

Comments (2)

syhaffert avatar syhaffert commented on September 15, 2024

There is indeed a mistake in the interface of the Zernike class. The current implementation assumes that the phase dot diameter has a physical size. But the documentation says the size should be given in units of lambda/D. I have fixed this bug in my current working branch.

The temporary fix until I have merged the new branch is to give the phase dot diameter in physical units.

from hcipy.

ehpor avatar ehpor commented on September 15, 2024

I'd like to get this merged sooner. I'll make a separate PR for this right now. A PR should only address a single thing, not a whole slew of fixes @syhaffert.

from hcipy.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.