Giter Club home page Giter Club logo

Comments (7)

syhaffert avatar syhaffert commented on August 11, 2024

Maybe as a similar issue, how will we handle standard refractive index profiles? Do we make a separate glass.py file?

from hcipy.

ehpor avatar ehpor commented on August 11, 2024

Yes, I think it's a good idea to have a small library of these aspheric, conic and spherical surface sags. I'd keep it brief though. To make them useful outside of micro-optics would probably need more advanced optical propagation methods, which are not implemented now. Any more than the following?

  • Even aspheric
  • Even-odd aspheric
  • Conic
  • Spherical

For refractive indices. A wrapper to an existing library would be preferable for me, but I haven't seen any good ones. PyTMM looks okay, but that is not pip installable as far as I can see, and including it outright into HCIPy or a derivative is not possible due to their license. Maybe a few formulas for the most common glasses (BK7, SF11, ...) and a few general implementations (Sellmeier, ...), with coefficients as arguments? Into glass.py would be my choice as well.

from hcipy.

syhaffert avatar syhaffert commented on August 11, 2024

I think those surfaces are fine. I will add them in my current working branch in a separate surface file.

For the refractive index I think we may be able to use: https://github.com/HugoGuillen/refractiveindex.info-sqlite

This one has no license and has a relatively simple interface. It also allows you to look for materials within certain ranges of refractive indices.

from hcipy.

ehpor avatar ehpor commented on August 11, 2024

That one is also not pip-installable, and is also based on PyTMM, and as such, must also necessarily be GPL licensed, even though it says it's not. If you look in the code, a large part is copy-pasted with small modifications. You can not re-release a GPL code as non-licensed code or MIT licensed, even if you modify it. While officially, we wouldn't be directly breaking the license, we would do it indirectly.

from hcipy.

syhaffert avatar syhaffert commented on August 11, 2024

Well then it would be easiest to include several glasses by hand. I have already implemented a couple of Cauchy and Sellmeier equations.

from hcipy.

syhaffert avatar syhaffert commented on August 11, 2024

I have added the two standard glass catalogues from Schott and Ohara in my branch (fiber_LP_modes). Those were freely available from the website of Schott and Ohara. How should we order such files? Currently I just put them in the optics folder, like the xinetics influence functions. Should we add some Data folder at some point for these types of files?

from hcipy.

syhaffert avatar syhaffert commented on August 11, 2024

This has now been resolved in the new LP_fiber_modes branch, therefore I will close this issue.

from hcipy.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.