Comments (3)
My original plan for this was to have a Propagator
child class that did this, without any function like the one you propose. That class would decide on the propagator to use based on its input wavefront (including the pilot Gaussian beam). It would internally use the FresnelPropagator
and FraunhoferPropagator
to propagate from plate to spherical and spherical to plane (via the waist of the Gaussian beam). Why do you need your proposed function? It avoids the need for internal storage of the propagators, but it complicates user code.
FYI, something related: I'd like to revert to the old way of doing the agnostic optical elements. I realize now that having the optical element be agnostic to input grid was a mistake and overcomplicates things. I'm currently using an intermediate solution myself, where the input grid and future Gaussian beam are fixed after (lazy) initialization, but optical elements should still be able to handle input wavefronts with different wavelengths. That has worked out so far, and I aim to push that after SPIE (and my holiday). It simplifies internal hcipy code, especially for the planned multi-backend support, and is almost equivalent for user code.
I wholeheartedly agree with never renaming classes. Having aliases however is always an option.
from hcipy.
A child class works for me too. The planar to spherical (and vice-versa propagation) is a bit different from the Fraunhofer propagation, right? It's factor * quadratic_phase(output_grid) * Fourier Transform{ quadratic_phase(input_grid) }
.
The quadratic phases have to be added and the spatial frequency sampling is different? Or is the sampling equal if the propagation distance is chosen instead of the focal length?
Yeah I think the current agnostic implementation is indeed a little bit over engineered.
from hcipy.
Just writing to say that this would be a very nice feature enhancement for HCIpy. I use but dislike the ZEMAX Physical Optics Propagation, and was playing around with HCIpy to see whether it could provide an alternative. I am looking for something that can model the surface errors from optics, and estimate the PSF for a realistic optical system (in this case, Keck AO + SCALES). Unless I am missing something this is not possible to do (easily? at all?) since much of the propagation I will want to model is in non-collimated space.
Great tool, otherwise - by the way.
from hcipy.
Related Issues (20)
- `VectorVortexCoronagraph.backward()` is broken HOT 3
- Deterministic atmospheric phase screens #173 HOT 2
- 'gaussian_mode' is not defined HOT 8
- Is it possible to remove specific modes in atmospher layer using HCIPy? HOT 4
- Add a function to pad regularly-spaced grids HOT 4
- Observing a Satellite (e.g. ISS) HOT 2
- `utcnow` is deprecated in Python 3.12
- Add support for Python 3.11.
- Drop support for Python 3.7. HOT 1
- The random function in the deformable mirror is not functioning properly HOT 2
- Matplotlib 3.7 `get_cmap()` deprecation warning
- Numpy 1.25 deprecation warning
- Imageio v3 API changes.
- Add support for Python 3.12.
- Add support for geometric operations
- pip install hcipy not complete? HOT 2
- Add grid indexing support when indexing or slicing a Field HOT 2
- docstring error in FraunhoferPropagator (?) HOT 2
- Non ideal optics to emulate manufacturing errors?
- FraunhoferPropagator total power not conserved HOT 6
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from hcipy.