Giter Club home page Giter Club logo

Comments (7)

brucellino avatar brucellino commented on June 25, 2024 1

I updated hugo to https://github.com/gohugoio/hugo/releases/tag/v0.123.4 and got a different error now:

Error: "/home/sebastian/devel/EGI-Federation/documentation/layouts/shortcodes/tabx.html:2:1": parse failed: template: shortcodes/tabx.html:2: unterminated quoted string

Prettier broke the template:

-{{ with $.Parent }}
-{{ if ne $.Parent.Name "tabpanex" }}
-{{ errorf "tabx must be used within a tabpanex block" }}
-{{ end }}
-{{ end }}
+{{ with $.Parent }} {{ if ne $.Parent.Name "tabpanex" }} {{ errorf "tabx must be
+used within a tabpanex block" }} {{ end }} {{ end }}
 
 <!-- Prefill header if not given as parameter -->
 {{ $header := default (printf "Tab %v" ( add $.Ordinal 1)) (.Get "header") }}
 
 <!-- store all tab info in dict tab -->
-{{ $tab := dict "header" $header }}
-{{ with $.Inner }}
-{{ $tab = merge $tab (dict "content" $.Inner) }}
-{{ end }}
+{{ $tab := dict "header" $header }} {{ with $.Inner }} {{ $tab = merge $tab
+(dict "content" $.Inner) }} {{ end }}
 
 <!-- add dict tab to parent's scratchpad -->
-{{ with .Parent }}
-{{ $.Parent.Scratch.SetInMap "tabs" (printf "%v" $.Ordinal) $tab }}
-{{ end }}
+{{ with .Parent }} {{ $.Parent.Scratch.SetInMap "tabs" (printf "%v" $.Ordinal)
+$tab }} {{ end }}

My bad - I forgot to include layous/** (there were only the partials included in the orginal prettier config).
I've tested and it works. If you like, I can push the update to the branch you're working on, or you can just apply this patch in .prettierrc.toml:

 [[overrides]]
-files = ["layouts/partials/*.html"]
+files = ["layouts/**/*.html"]

This is a different story though:

Sorry, how can I pin docsy to 0.9.1? I think I get it installed with:

git submodule update --init --recursive --depth 1

Docsy's own documentation recommends using Hugo modules, which I would vastly prefer to using a submodule. I tried it last night, and:

  1. It works
  2. It removes ~ 80M from the repo
  3. We can explicitly declare the dependency and pin the version hugo mod get github.com/google/[email protected]

I will propose in a new issue a move from using the submodule to using a hugo module which we can better manage.

from documentation.

sebastian-luna-valero avatar sebastian-luna-valero commented on June 25, 2024

Error message links to: https://gohugo.io/content-management/multilingual/#changes-in-hugo-01120

from documentation.

sebastian-luna-valero avatar sebastian-luna-valero commented on June 25, 2024

Ok, so the deprecation warnings can be removed with:

diff --git a/config.toml b/config.toml
index 6243e825dc..af510abab2 100644
--- a/config.toml
+++ b/config.toml
@@ -16,7 +16,7 @@ defaultContentLanguageInSubdir = false
 # Useful when translating.
 enableMissingTranslationPlaceholders = false
 
-disableKinds = ["taxonomy", "taxonomyTerm"]
+disableKinds = ["taxonomy"]
 
 # Highlighting config
 pygmentsCodeFences = true
@@ -63,10 +63,12 @@ anchor = "smart"
 [languages]
   [languages.en]
   title = "Documentation"
-  description = "EGI documentation"
   languageName = "English"
   # Weight used for sorting.
   weight = 1
+    [languages.en.params]
+    description = "EGI documentation"
+
 
 [markup]
   [markup.goldmark]

from documentation.

sebastian-luna-valero avatar sebastian-luna-valero commented on June 25, 2024

However, the issue is with docsy instead. Not sure how to solve that one.

from documentation.

brucellino avatar brucellino commented on June 25, 2024

@sebastian-luna-valero It's probably a good idea to pin the version of the module we're using, since it's pulling directly from the main branch of the upstream repo which the maintainers themselves say is volatile.

I got this working with: 1.123.4 and docsy 0.9.1 (same deprecation warning, but no error)

from documentation.

sebastian-luna-valero avatar sebastian-luna-valero commented on June 25, 2024

Thanks @brucellino

I updated hugo to https://github.com/gohugoio/hugo/releases/tag/v0.123.4 and got a different error now:

Error: "/home/sebastian/devel/EGI-Federation/documentation/layouts/shortcodes/tabx.html:2:1": parse failed: template: shortcodes/tabx.html:2: unterminated quoted string

Sorry, how can I pin docsy to 0.9.1? I think I get it installed with:

git submodule update --init --recursive --depth 1

which seems to get:

Submodule path 'themes/docsy': checked out 'f85c845226f30a4b2a55085d142e96def89e4c3f'

from documentation.

sebastian-luna-valero avatar sebastian-luna-valero commented on June 25, 2024

I can push the update to the branch you're working on

Please push to https://github.com/brucellino/egi-documentation/tree/main so it stays on the same PR

I will propose in a new issue a move from using the submodule to using a hugo module which we can better manage.

Thank you very much, really appreciated!

from documentation.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.