Markers bound fitting is not working. about ivory-google-map HOT 10 CLOSED

@ohmytribe Thx for reporting the issue but I need to investigate. Basically, I understand the map fit the bound before all extends are rendered (so, at this state, the bound is not correct) but AFAIR, as the bound is an object instance, extending it later should automatically update the map bound with all additional bound extend...

This example:

map.fitBounds(bound);
bound.extend(something);

should be equivalent to:

bound.extend(something);
map.fitBounds(bound);

Isn't it?

from ivory-google-map.

Thanks for the instant reply.

I tried to play with this in Chrome console. Simply adding marker to bound object that you previously used in fitBounds() method has no effect. You must call fitBound() method again to apply bound changes.

I think that map doesn't track changes to bound object that was previously used for fitting.

from ivory-google-map.

Okay, thx for the feedback, I will make a patch ASAP.

from ivory-google-map.

@ohmytribe Can you give a try to the referenced PR? Just add "egeloen/google-map": "dev-f-map-fit-bound@dev" in your composer.json.

from ivory-google-map.

I've tried to add this to composer but after that I'm getting next error while running composer update:

Your requirements could not be resolved to an installable set of packages.

   Problem 1
    - egeloen/google-map-bundle 2.1.3 requires egeloen/google-map 1.3.* -> no matching package found.
    - egeloen/google-map-bundle 2.1.2 requires egeloen/google-map 1.2.* -> no matching package found.
    - egeloen/google-map-bundle 2.1.1 requires egeloen/google-map 1.1.* -> no matching package found.
    - egeloen/google-map-bundle 2.1.3 requires egeloen/google-map 1.3.* -> no matching package found.
    - Installation request for egeloen/google-map-bundle 2.1.* -> satisfiable by egeloen/google-map-bundle[2.1.1, 2.1.2, 2.1.3]

from ivory-google-map.

Sorry, try with "egeloen/google-map": "dev-f-map-fit-bound as 1.3.0"

from ivory-google-map.

Bounds work perfectly. I think this could be merged.

Thanks a lot.

from ivory-google-map.

Thx for your feedback. Everything should be fixed!

from ivory-google-map.

@egeloen sorry, again... my last problem is related with this issue, but in my case I'm using IvoryGoogleMapBundle 3.x

I'm trying this solution https://github.com/egeloen/ivory-google-map/blob/master/doc/map.md#fitting-a-bound-which-extends-overlayslayers but it doesn't works...

from ivory-google-map.

Open a new issue please instead of writing on an old one :) Give me as much informations as possible and I will take a look to it.

from ivory-google-map.