Giter Club home page Giter Club logo

Comments (10)

efroemling avatar efroemling commented on May 24, 2024

Sure thing; I was mucking with the chat/screen-messaging code earlier so I went ahead and added this. It's in commit c95357e
_ba.chatmessage() now has an optional 'clients' arg the same as ba.screenmessage(). The only limitation is it only works from the server.

I also replaced the mgr.broadcast() method in the server-wrapper with mgr.chatmessage() and mgr.screenmessage() so you can play with both from there interactively if you want. (it just forwards those calls along to the running binary)

I'm wondering if we'll need a bit more here such as the ability for the server to override the name on the chat message that goes out (so if the server handles forwarding private messages they don't appear to be coming from the server, etc)

from ballistica.

sudo-logic avatar sudo-logic commented on May 24, 2024

Oh nice, did not know that this was already added.
The name overwrite looks good. A 'PM' label in front of the message could be useful to indicate private messages.

Also if possible, please add a clearscreen command which would be used to clear out all the messages/chats from the main screen.
I currently use a hacky way of doing this: bs.screenMessage('\n'*10000)

All of these if used properly would completely eliminate all disturbances during gameplay.

from ballistica.

efroemling avatar efroemling commented on May 24, 2024

Well, it wasn't added already, but I added it after you suggested it since I was changing that code already :)
I'll try to add the name overwrite and clearscreen commands today...

from ballistica.

efroemling avatar efroemling commented on May 24, 2024

Ok, I just added a 'sender_override' arg in chatmessage() in the latest commit: d260ace

I looked into a screenmessage reset function, but it would require me to change the netplay protocol, which isn't something I want to do until 1.5 is well distributed. So I hope you don't mind doing without that for now.

Let me know if the chatmessage stuff seems to be workable for now and I'll go ahead and close this thread.

from ballistica.

SushrutShidhaye avatar SushrutShidhaye commented on May 24, 2024

Can we get option to disable On Screen Left, join and leave Mesaages and also on screen chat messages.
some players spam server by left joining again and again and send big messages and also after kicking they can use random ids and just irritate us ....
Hope u will help....

from ballistica.

efroemling avatar efroemling commented on May 24, 2024

Ok I'll look into that stuff and see what is doable easily. (other stuff might have to wait until after 1.5 launch)
I'm wondering if it might make sense to ban IP addresses and not just account IDs... that might at least be harder for people to work around.

from ballistica.

SushrutShidhaye avatar SushrutShidhaye commented on May 24, 2024

But using vpn they can join still its good if he is a noob spammer who even dont know about vpn and all...😅

from ballistica.

sudo-logic avatar sudo-logic commented on May 24, 2024

As much as I know about spamming BS Servers, AccountName (Android1234567 or AwesomeLogic) can be easily spoofed, but on the other hand I've never seen someone manage to spoof their account_id (pb-....).

Currently account_id is only available once the player sends the request to join the lobby.

So there's no way (as much as I know) to get the account_id of a client as soon as they join the server.

Most spam issues could be fixed if _ba.get_game_roster() also gave the account_id of clients as soon as they joined the server, the issue being that there's no way to tell if a client is using spoofed AccountName until it tries to join the lobby.

In Short: Adding a account_id key for every client in _ba.get_game_roster() would fix most spam issues as it is a robust and non-spoofable way of uniquely identifying players. At-least till the day someone manages to spoof account_id like Account Names :/
Access to IP Addresses would be cool too. Though that list can currently be made using packet capturing and matching them with join requests. (Another hacky way)

The issue was about 'Targeted Chat Messages' which seem to have been sorted out. This issue can be closed now I guess?

from ballistica.

SushrutShidhaye avatar SushrutShidhaye commented on May 24, 2024

Yes,
But this thing will work only on android id (Android123456) and Google Id(only one google account) because making new pc id and using other google account will change pb- id too(i think).

and as per you suggest he(eric) also need to give more access to servers owners like kick or ban someone from running server using chat commands ( but it will need to kick or ban pb- id so he cannot join if he change just google id name) and he can join still if he use other google
account...
Or just we can increse left join timing or as i suggest disable on screen left join and leave pop-ups( option to turn on popups or off)...

from ballistica.

efroemling avatar efroemling commented on May 24, 2024

Hey folks; gonna close this and move the discussion to #41

from ballistica.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.