Giter Club home page Giter Club logo

Comments (6)

nissaba avatar nissaba commented on May 25, 2024 1

Thanks. I have accepted it.

from efcolorpicker.

EyreFree avatar EyreFree commented on May 25, 2024

The brightness slider works well in demo project, can you provide more details?

from efcolorpicker.

nissaba avatar nissaba commented on May 25, 2024

if you move the brightness slider the color picker is not updated, only the current color is.
simulator screen shot - iphone se - 2018-02-26 at 13 22 47
simulator screen shot - iphone se - 2018-02-26 at 13 22 54
simulator screen shot - iphone se - 2018-02-26 at 13 22 58

in the 3 images the color selection disk/circle is alway the same.
normaly in other tools this would update to become fully black if the brightness slider is set to 0
and as the brightness increases the colors in the picker disk would get brighter as it goes up the scale.

as can bee seen in the following images example from XCode color picker.
capture d ecran 2018-02-26 a 13 29 29
capture d ecran 2018-02-26 a 13 29 38
capture d ecran 2018-02-26 a 13 29 44

from efcolorpicker.

nissaba avatar nissaba commented on May 25, 2024

Sorry for the UGE image size.

from efcolorpicker.

nissaba avatar nissaba commented on May 25, 2024

Hi. I finally noticed that in HSB the brightness bar changes as you move the small selector disk. and this is where you know the outcome of the color with adjust brightness will be. The Slider bar is ever so thin it is hard to see and I did not noticed until today that it was chaging as I was moving the selector in the color wheel.

So 1 suggestion is to make that bar thiker, so people that are presbyopic (like me) can notice the change. I did ask my graphic desinger to play with it, he also did not notieced that the sliderbar was chainging color and he as good eyesight.

An other solution is to keep the slider bar on a black to withe gradiant and have the colorwheel update its colormap base on the brightness.

I have updated my fork, as you change the brightness the color map updates.

from efcolorpicker.

EyreFree avatar EyreFree commented on May 25, 2024

Thanks for your contributions. Your PR has been merged.

You are the first user I know to actually use this library. Are you interested in being a collaborator of this project? In this way, you will be more convenient for the modification and development of this project.

I sent you a invitation, click the link to see: https://github.com/EyreFree/EFColorPicker/invitations.

😀

from efcolorpicker.

Related Issues (16)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.