Giter Club home page Giter Club logo

Comments (4)

IMax153 avatar IMax153 commented on August 28, 2024 1

Thanks @stazz! Personally I don't think it's 100% necessary and would probably end up complicating our CI pipeline. We're pretty careful about only exposing things from the library that are going to end up in the declaration files.

That being said - I'll leave it up to @mikearnaldi for the final word.

from io.

IMax153 avatar IMax153 commented on August 28, 2024

@mikearnaldi - given that our build process in-lines the op codes anyways, we should probably just consider removing op codes entirely.

from io.

IMax153 avatar IMax153 commented on August 28, 2024

@leighman - I believe this should be closed by 985dca4 once released. Going to close this issue. Thanks for the report!

from io.

stazz avatar stazz commented on August 28, 2024

@IMax153 Would it make sense to add a step into CI/CD pipeline, which would try to compile a simple TypeScript file, which would just import the .d.ts code produced by compilation of the source code in this repo? That would help to avoid similar errors in the future. At least I use similar approach in my own libraries, and it has helped me catching few similar errors to this one.

I can open separate ticket for that if you think that's good idea. Maybe even make a PR :)

from io.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.