Giter Club home page Giter Club logo

Comments (22)

benbender avatar benbender commented on May 21, 2024 1

@EETagent It seems that you copied my config from the X1C6 but it differs from the T480. F.e. S03 is internal and SDCard on the T480 because the T480 only has one TB-port.

Edit: proposed my config in #58

from t480-opencore-hackintosh.

EETagent avatar EETagent commented on May 21, 2024 1

No _UPC to XUPC rename ...

Will fix that and report back

from t480-opencore-hackintosh.

EETagent avatar EETagent commented on May 21, 2024 1

Webcam, Bluetooth and SD Card finally works! Thanks @benbender for all your help

from t480-opencore-hackintosh.

EETagent avatar EETagent commented on May 21, 2024

Hi @Charlyo

Thanks for testing experimental branch. I actually did not test webcam and Bluetooth since moving to SSDT-XHC, Bluetooth tray icon on Big Sur is not crossed out when unavailable unlike on Catalina so this change went undetected :) I already edited draft's false description. For now you can remove this patch and add USBMap/USBPorts back.

@benbender
image

HS08, HS07 and SS03 are undetected and neither of them works. How we can help to solve this?

Current HS08 config looks OK to me

0xFF - Port is enabled
0xFF - Internal connector type
Zero, 
Zero

from t480-opencore-hackintosh.

Charlyo avatar Charlyo commented on May 21, 2024

Thanks for the update @EETagent!!

Actually, if you think it through, only the "internal" ports fail.

from t480-opencore-hackintosh.

EETagent avatar EETagent commented on May 21, 2024

Thanks @benbender,

sadly the situation has not changed. These 3 USB devices still does not work.

from t480-opencore-hackintosh.

benbender avatar benbender commented on May 21, 2024

A bit more info would be nice :) IOReg-dump? Logs? Is the SSDT applied? Rename for _UPC to XUPC in place?

PS: The SSDT itself and those devices are working as I'm running it right now on my T480.

from t480-opencore-hackintosh.

benbender avatar benbender commented on May 21, 2024

If your config.plist from the YogaSMC-branch is complete, you are missing the needed patch:

			<dict>
				<key>Comment</key>
				<string>XHC: _UPC to XUPC</string>
				<key>Count</key>
				<integer>0</integer>
				<key>Enabled</key>
				<true/>
				<key>Find</key>
				<data>X1VQQw==</data>
				<key>Limit</key>
				<integer>0</integer>
				<key>Mask</key>
				<data></data>
				<key>OemTableId</key>
				<data>UHJvalNzZHQ=</data>
				<key>Replace</key>
				<data>WFVQQw==</data>
				<key>ReplaceMask</key>
				<data></data>
				<key>Skip</key>
				<integer>0</integer>
				<key>TableLength</key>
				<integer>6103</integer>
				<key>TableSignature</key>
				<data>U1NEVA==</data>
			</dict>

This patch renames all USB-port-definitions in ACPI and redoes them. Today I refined my XHC-SSDT for the X1C6. It may be worth to adapt those changes. This patch may need adaption for the table-length to get applied.

For the future: please check if patches you adapt from me are cleanly applied. In this case they can't be without that patch as the _UPC-definitions collide. Check with a search for AE_ in log show --last boot.

from t480-opencore-hackintosh.

EETagent avatar EETagent commented on May 21, 2024

For the future: please check if patches you adapt from me are cleanly applied. In this case they can't be without that patch as the _UPC-definitions collide. Check with a search for AE_ in log show --last boot.

It does not seem so ( With _XUPC rename in place )

image

from t480-opencore-hackintosh.

benbender avatar benbender commented on May 21, 2024

You are patching a SSDT. This is different from patching DSDT as it needs the correct Table-signature and length to be applied because there can (and will) be multiple SSDT's on the system. Both values can be found in the header of the SSDT to be patched. View the original XHC-SSDT with MacIASL and adapt the patch accordingly. As said above, the patch is taken from my X1C6 as I only have that at hand.

Additionally, grep'ing for AE_ only shows that there are errors. To see the message, grep after AppleACPIPlatform in the logs. The actual error-messages are below the lines starting with AE_.

PS: I urgently need to do a writeup on how to do basic ACPI-debugging :)

from t480-opencore-hackintosh.

EETagent avatar EETagent commented on May 21, 2024

image

PS: I urgently need to do a writeup on how to do basic ACPI-debugging :)

Yes, that would be great :)

from t480-opencore-hackintosh.

benbender avatar benbender commented on May 21, 2024

As I said - The patch isn't applied because OpenCore can't find the table.

				<key>TableLength</key>
				<integer>6103</integer>

Probably only the length needs to be adapted. Please switch the value with the one found in the original SSDT for the T480 in MacIASL.

from t480-opencore-hackintosh.

EETagent avatar EETagent commented on May 21, 2024

Length replaced, SSDT still does not run
image

from t480-opencore-hackintosh.

Charlyo avatar Charlyo commented on May 21, 2024

@EETagent have you changed OemTableId to the actual file one?

from t480-opencore-hackintosh.

EETagent avatar EETagent commented on May 21, 2024

@EETagent have you changed OemTableId to the actual file one?

Well, no. Currently there is ProjSsdt, will replace it with _XHC

from t480-opencore-hackintosh.

Charlyo avatar Charlyo commented on May 21, 2024

Not sure if necessary, just felt weird (at least to me).

from t480-opencore-hackintosh.

EETagent avatar EETagent commented on May 21, 2024
 * Original Table Header:
 *     Signature        "SSDT"
 *     Length           0x0000064E (1614)
 *     Revision         0x02
 *     Checksum         0x9D
 *     OEM ID           "T480"
 *     OEM Table ID     "_XHC"
 *     OEM Revision     0x00001000 (4096)
 *     Compiler ID      "INTL"
 *     Compiler Version 0x20200925 (538970405)
 */
  • OemTableId _XHC (5F584843)
  • TableLenght 1614
  • TableSignature SSDT (53534454)

Rename still does not apply.

from t480-opencore-hackintosh.

benbender avatar benbender commented on May 21, 2024

Length replaced, SSDT still does not run
image

Thats the length of your SSDT, not the original. The original is ProjSsdt as @Charlyo said and should be longer.

from t480-opencore-hackintosh.

EETagent avatar EETagent commented on May 21, 2024

Length replaced, SSDT still does not run

Thats the length of your SSDT, not the original. The original is ProjSsdt as @Charlyo said and should be longer.

I am idiot, will fix it immediately

from t480-opencore-hackintosh.

EETagent avatar EETagent commented on May 21, 2024

OK, so length of ProjSsdt is 5692

from t480-opencore-hackintosh.

EETagent avatar EETagent commented on May 21, 2024

@Charlyo Fixed in 4ef5625

Please try and report back

from t480-opencore-hackintosh.

Charlyo avatar Charlyo commented on May 21, 2024

Working perfectly on last commit!

from t480-opencore-hackintosh.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.