Path error while setting up shifu demos in local system about shifu HOT 7 CLOSED

estdir to shifudemos, should I create a separate issue because:

• changes have to be made in this repo itself
• it is a good open-source practice to have a separate issue for uncommon changes so that it is easier to refer in future requests.

Hi @SuperAayush, sure please go ahead and create a separate issue for the renaming.

from shifu.

@SuperAayush Thank you for this issue and solution! We'll be making this change in our docs repo https://github.com/Edgenesis/shifu.run

from shifu.

Hey @leepala!!

Let me know if any help is needed from my end, if you are comfortable I can take up this issue and go for a PR for you to review 😄.

Thank You!!

from shifu.

Hey @SuperAayush, thanks for your question. We welcome your help in solving this problem!
All of Shifu's documents are in this repo https://github.com/Edgenesis/shifu.dev, welcome to make any changes and make PR.
The directory name does need to be updated, thanks for the suggestion, I think shifudemos is all right . If you want to fix it, you can update this shell script to do it.

from shifu.

Hey @SuperAayush, thanks for your question. We welcome your help in solving this problem! All of Shifu's documents are in this repo https://github.com/Edgenesis/shifu.dev, welcome to make any changes and make PR. The directory name does need to be updated, thanks for the suggestion, I think shifudemos is all right . If you want to fix it, you can update this shell script to do it.

The current name of the directory is testdir, should we change it to shifudemos ?
testdir is very usual name will be very hard to navigate.

from shifu.

yep, let's change it to shifudemos instead of testdir☺️

from shifu.

Hey @SuperAayush, thanks for your question. We welcome your help in solving this problem! All of Shifu's documents are in this repo https://github.com/Edgenesis/shifu.dev, welcome to make any changes and make PR. The directory name does need to be updated, thanks for the suggestion, I think shifudemos is all right . If you want to fix it, you can update this shell script to do it.

To make the change in the directory name from testdir to shifudemos, should I create a separate issue because:

• changes have to be made in this repo itself
• it is a good open-source practice to have a separate issue for uncommon changes so that it is easier to refer in future requests.

cc - @tomqin93 @leepala

from shifu.