AssertionError when creating a scalar type with the same name as an existing object type in esdl about edgedb HOT 1 OPEN

Additionally, if the existing object type doesn't have any properties or links, creating a scalar type with the same name would still return a clear error message.

Schema:

module default {
  type A {
    # No properties or links
  }
  scalar type A extending str;
}

Output:

$ edgedb migration create
error: scalar 'default::A' was already declared
  ┌─ /dbschema/default.esdl:5:3
  │
5 │   scalar type A extending str;
  │   ^^^^^^^^^^^^^^^^^^^^^^^^^^^ error

edgedb error: cannot proceed until .esdl files are fixed

After reading the source code, I noted that the ctx.objects is indexed based on object full names. So when a CreateScalarType with the same name follows an existing CreateObjectType, the existing CreateObjectType is overwritten in ctx.objects. This leads to an AssertionError when processing the sub-commands of CreateObjectType such as CreateConcretePointer.

from edgedb.