Package version 6.0.1 Describe the bug <p

Just check if slot exists using <div class="highlight highlight-text-html-edge not

<named slot> is not a function,about edge-js/edge

Comments (6)

thetutlage commented on June 24, 2024

Just check if slot exists using

@if($slots.head)
<head>
  {{{ await $slots.head() }}}
</head>
@end

from edge.

pete-gi commented on June 24, 2024

Ok, I can. But it's a huge step back. I know I don't have to explain to you how it worked in Adonis v5, but it requires more code to achieve the same result.
Templating engine lacks now functionality that worked before pretty well. It's a regression.

from edge.

RomainLanz commented on June 24, 2024

But it's a huge step back

This is a strong statement for one additional line of code.

It totally makes sense to verify that a slot exists before trying to use it. In fact, before, you were generating bad HTML because you had an empty <head> tag.

from edge.

pete-gi commented on June 24, 2024

In fact, before, you were generating bad HTML because you had an empty tag.

That's just an example with the smallest amount of HTML anyone needs in this issue.

This is a strong statement for one additional line of code.

One line of code for every slot. You don't know what's the scope of the projects people are working on.

But.
WebComponents don't need conditionals for slots. Vue doesn't need.
Twig for PHP has blocks like the sections before and doesn't need if statement. Laravel Blade the same.

I know I can make a global function or @component that can take care of this conditional for me. I'm working with Adonis since v5 released and having to write more code for something that was already there in previous version for years is a regression.

from edge.

thetutlage commented on June 24, 2024

Using components for layouts is a very common practice. Just search for the same in the Vue ecosystem or in the React ecosystem.

Yes, they work different from layouts in first place and you just have to find the right pattern with them.

But anyways, we won't be adding layouts back now. So the debate around the advantages and disadvantages won't help much.

from edge.

pete-gi commented on June 24, 2024

Using components for layouts is a very common practice. Just search for the same in the Vue ecosystem or in the React ecosystem.

I work with them on the daily basis for 5 years, I don't have to search for it.

I just wanted to not use the if statement for checking whether the slot exists. That was the issue. You removed it from previous version of Edge.
But ok, you're not doing anything in this matter, I do accept this and go back to something that works as it should.

from edge.

Recommend Projects

<named slot> is not a function about edge HOT 6 CLOSED

Comments (6)

Related Issues (20)

Recommend Projects

React

Vue.js

Typescript

TensorFlow

Django

Laravel

D3

Recommend Topics

javascript

web

server

Machine learning

Visualization

Game

Recommend Org

Facebook

Microsoft

Google

Alibaba

D3

Tencent