Giter Club home page Giter Club logo

Comments (19)

dashodanger avatar dashodanger commented on June 14, 2024 1

I did yes, sorry I forgot to mention it here. That is currently fine, I'll check it once every few months to check that nothing gets broken with it.

Sounds good...as of commit fe68d3a, I tweaked the function for locating the default soundfont to account for the home directory location instead of just being a pure relative path. Next time you end up trying, will you let us know if that did the trick for MIDI music, or if there's any log messages indicating what might be failing?

from edge-classic.

dashodanger avatar dashodanger commented on June 14, 2024 1

Shoot, alright then...I'll update this when I have another inkling of what might be happening.

from edge-classic.

dashodanger avatar dashodanger commented on June 14, 2024 1

Going to close this out for inactivity and the fact that the current codebase is very different from when this issue first arose. If it's still happening on Mac, I can reopen it.

from edge-classic.

dashodanger avatar dashodanger commented on June 14, 2024

I like using it on the Window/Linux side, but if that's the case, at a minimum I can pull the prior GLEW contents and have them as the build option for Mac. I'm working through some other stuff on my local repo, but I'll add a comment to this thread when it has been restored.

from edge-classic.

dashodanger avatar dashodanger commented on June 14, 2024

dd22ba8 should hopefully have GLEW restored properly when building for Mac. I may try exploring other GL loaders that could work across all platforms, or maybe even just return to having GLEW as the only solution. I'll keep this open until I hear that it's working.

from edge-classic.

atsb avatar atsb commented on June 14, 2024

Thanks very much :) works fine (with a patch).

Mac Patch:
vm_hud.cc

#if defined _MSC_VER || defined __APPLE__
#include <cmath>
#endif

std::ceil is in cmath.h and Apple machines need this to compile.

from edge-classic.

atsb avatar atsb commented on June 14, 2024

One slight issue I have now observed. Music does not play on Mac.

from edge-classic.

dashodanger avatar dashodanger commented on June 14, 2024

I recently changed some of the filesystem functions...I wonder if it's not 'finding' the default soundfont now. Do internal MP3/OGG lumps still play with PWADs that have them?

from edge-classic.

atsb avatar atsb commented on June 14, 2024

Do you know any that contain those lumps? I don't think I've played any pwads that have those lumps except on ZDoom specific wads with module music.

from edge-classic.

dashodanger avatar dashodanger commented on June 14, 2024

I usually use the Harmony IWAD, since the title and first level are MP3 at least.

from edge-classic.

atsb avatar atsb commented on June 14, 2024

I'll get on this tonight, just keeping this updated.

from edge-classic.

dashodanger avatar dashodanger commented on June 14, 2024

I renamed the issue to reflect the current situation; did you ever have a chance to try out MP3/OGG music?

from edge-classic.

atsb avatar atsb commented on June 14, 2024

I did yes, sorry I forgot to mention it here. That is currently fine, I'll check it once every few months to check that nothing gets broken with it.

from edge-classic.

atsb avatar atsb commented on June 14, 2024

Well I've been trying out 1.1.. music does not play at all on a mac now. Even the default Doom midi, nothing. Only sound effects.

from edge-classic.

dashodanger avatar dashodanger commented on June 14, 2024

Well I've been trying out 1.1.. music does not play at all on a mac now. Even the default Doom midi, nothing. Only sound effects.

I did a goof and did "home_dir" instead of "game_dir", forgetting that on non-Windows those are sometimes distinct locations.
625d45c should at least correctly look for the soundfont relative to the directory the executable as in. This fixed the issue when I encountered it on my Pi; I'll test on a Mac when I can.

from edge-classic.

atsb avatar atsb commented on June 14, 2024

I'll test it later so I'll probably beat you to it :)

from edge-classic.

atsb avatar atsb commented on June 14, 2024

This still happens.

from edge-classic.

atsb avatar atsb commented on June 14, 2024

I'll give it a test and let you know

from edge-classic.

dashodanger avatar dashodanger commented on June 14, 2024

I'll give it a test and let you know

Sounds good...actually, if it doesn't work would you mind opening a new issue? I forgot that this initially started as a Glatter vs. GLEW issue and it might be confusing for others

from edge-classic.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.