Giter Club home page Giter Club logo

Comments (3)

dashodanger avatar dashodanger commented on June 3, 2024

Thank you (again) for the excellent test map and documentation; while I try to work this I have a quick question. Do you know of any PWADs "in the wild" off the top of your head where this effect can be observed? I've made the mistake before of assuming everything was good because it works in an example WAD (like BOOMEDIT for instance) but things fail in the "real world"

from edge-classic.

simc2 avatar simc2 commented on June 3, 2024

I stumbled on this by accident on my own (complevel 9 minimum) map.
Saturnine Chapel does use Boom generic floor changers in it's round floor cyberdemon fight.
https://www.doomworld.com/idgames/levels/doom2/Ports/s-u/satchap

As with the Doom/Boom regular triggers only the

  • 177/159/84/37 Floor lower to lowest floor, change texture and type
  • 78/241/240/239 Floor change texture and effect to nearest
  • (191/9/155/146 Floor raise donut lower pillar)

use the numeric mode. With the probably most common types 37 and 9 I'd assume it's likely quite rare if there are several different flats or sector types at the target height. Though it's not impossible.

from edge-classic.

dashodanger avatar dashodanger commented on June 3, 2024

As of 18d4745, I think all of your concerns have been fixed. There were basically four issues at hand:
1 - As you suggested, the Boom generalized special processing was correctly identifying the model but assigning the opposite behavior.
2 - When looking for an appropriate surrounding sector, the linedefs that comprise a sector were being iterated through in reverse order and returning the first 'match'. This resulted in the highest (numerically) linedef being returned. They will now be iterated through in the order that they were assigned to the sector, which should result in the first matching linedef being the lowest index.
3 - From what I can tell by looking at the existing codebase, Tx0 and Tx changer types were never implemented. It seems like the assumption was that either both texture and type were changed or that nothing was changed.
4 - Changers already at the height of the target sector were never being executed. Our lifetimes and creation of plane movers differs a bit from Boom's thinkers in this regard and has always caused a bit of friction.

from edge-classic.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.