Giter Club home page Giter Club logo

Comments (11)

BenQoder avatar BenQoder commented on August 17, 2024 2

I will attempt making a PR to this effect and see how far I can go.

from binance-trade-bot.

edeng23 avatar edeng23 commented on August 17, 2024 1

@abanchev I agree, if a direct pair exists the bot should make a direct hop. Since I never ran the bot with ETH and BTC I didn't bother to add this logic. I'll do it as soon as I'm done with all my tests in Uni, or let someone else make a PR.

from binance-trade-bot.

CTetford avatar CTetford commented on August 17, 2024 1

Anyone willing to test, feel free:
#84

from binance-trade-bot.

Cactii1 avatar Cactii1 commented on August 17, 2024 1

This is really important because when using USDT there is double the tx fees because it's two trades that are executed to get from one coin to the other.

from binance-trade-bot.

remriel avatar remriel commented on August 17, 2024

Yes

supported_coin_list = [u'BTC', u'ETH']

from binance-trade-bot.

abanchev avatar abanchev commented on August 17, 2024

Do not do it like this, there is a direct ETHBTC pair, so you don't need to pass through USD (and lose money in fees and potential slippage). You will need to write your own function to do the trade directly if one of the coins is BTC

from binance-trade-bot.

remriel avatar remriel commented on August 17, 2024

I think the reason to use USDT is that it's more stable and you can accumulate more BTC/ETH this way.

from binance-trade-bot.

BitcoinerInCanada avatar BitcoinerInCanada commented on August 17, 2024

I'm going it a go now and will report my findings.

Is there a way to change the script so that it will trade the coins when there is certain percentage difference between the coins when up against the usdt?

from binance-trade-bot.

CTetford avatar CTetford commented on August 17, 2024

Yeah it's definitely possible. I've added in a "minimum profit" percentage variable to my script. I ran some backtesting and found 3-4% profit gives the best results, but it was with what limited data I could find.

I set up a simulation version where it uses price info from here:
http://www.cryptodatadownload.com/data/gemini/

There's per-minute pricing for BTC, LTC, ETH, and ZEC.

from binance-trade-bot.

BitcoinerInCanada avatar BitcoinerInCanada commented on August 17, 2024

Nice. I got the script and it is running now. I'll provide feedback in the morning

from binance-trade-bot.

remriel avatar remriel commented on August 17, 2024

I tried doing this but I'm getting errors. I added BTC and ETH to the supported coin list and set the bridge to ETHBTC.

2021-04-05 17:26:24,355 - crypto_trader_logger - INFO - Started
2021-04-05 17:26:25,261 - crypto_trader_logger - INFO - Creating database schema if it doesn't already exist
2021-04-05 17:26:25,679 - crypto_trader_logger - INFO - Initializing vs
2021-04-05 17:26:25,680 - crypto_trader_logger - INFO - Skipping initializing BTCETHBTC, symbol not found
2021-04-05 17:26:25,680 - crypto_trader_logger - INFO - Initializing vs
2021-04-05 17:26:25,681 - crypto_trader_logger - INFO - Skipping initializing ETHETHBTC, symbol not found
2021-04-05 17:26:31,137 - crypto_trader_logger - INFO - Skipping scouting... current coin BTCETHBTC not found
2021-04-05 17:26:36,577 - crypto_trader_logger - INFO - Skipping scouting... current coin BTCETHBTC not found

from binance-trade-bot.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.