Why does PerfForesightLabeled inherit from ConsIndShock? about hark HOT 7 CLOSED

because IndShockLabeledType needs to import from IndShockConsumerType and PerfForesightLabeled, and I thought this was a good way to avoid multiple inheritance, which I still don't understand very well.

If there is a better way to do it, then we should do that!

from hark.

There's a better way. I am utterly baffled at how this class manages to initialize and run. It needs income shock parameters to be passed to it... but they're not in its default dictionary!

from hark.

they are in the parent's default dictionary!

from hark.

They are not! This class inherits from IndShockConsumerType, but uses the perfect foresight dictionary as its default:

I'll check in a moment, but I suspect the explanation is that all of the tests are using a custom dictionary, not the default one.

from hark.

What is the default dictionary of IndShockConsumerType?

from hark.

Ok, I see now. Hopefully I can work it out.

from hark.

This is now fixed in #1410 by manually re-adding the (unexpectedly needed) constructors. It's wonky because update is being run multiple times during initialization. In the future, I think we should work toward update or construct not being called automatically during initialization, and have the user do it manually.

from hark.