Comments (2)
md5 is only deprecated for security purposes. It's perfectly fine to use md5 from hashlib for creating a unique hash.
In this case, however, I'm really not sure why the cache key is being created in this way at all. You may as well just use the actual hostname instead, since it's already a string to begin with and there is (at worst) a one-to-one correspondence between a hostname and its hashed version.
But just to be clear: the reason md5 is deprecated in Django is because it exists as a built-in in later versions of Python, not because there's anything wrong per-se with md5. Yes, md5 should no longer be used for security purposes, but as a very fast hashing function it's definitely better than Python's built-in hash
. Python's hash function is not intended to create reliably unique pointers to values. The hash is just an 8 byte integer; an md5 hash is 16 bytes. So md5 has half the number of potential collisions.
from django-multisite.
Closing for the reasons outlined by @JordanReiter above
from django-multisite.
Related Issues (20)
- Incorrect cache prefix documentation HOT 2
- Remove template.loaders.cached.py HOT 1
- Doesn't work with django_debug_toolbar HOT 1
- django-multisite how to set the correct database for the site based on subdomain HOT 1
- remove deprecated PathAssistedCurrentSiteManager HOT 1
- Support django 2.0
- Template dir for local development HOT 7
- KeyError at / 1 HOT 8
- Resolve normalized domain names
- Advantages of django-multisite HOT 1
- AliasInline should override `get_queryset`, not `queryset`
- New PyPi release HOT 2
- What current version of Django does this support? HOT 2
- suggest running `black` formatter on code before push HOT 1
- Middleware compatibility with Django 2 HOT 1
- Request for an example
- Crash on tldextract==3.0.0
- Django 3.2 breaks django-multisite: The SITE_ID setting must be an integer HOT 7
- Template loader alters path, can't find template again
- About Django 3.2 support HOT 2
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from django-multisite.