Implement some way to "clone" builders about milo HOT 6 CLOSED

What if there was a copy() method hanging off OpcUaClientConfig instead which returned a OpcUaClientConfigBuilder with all of the values pre-set from the config. This way you're not encouraged to leave some reference to a mutable, non-thread-safe object like a builder laying around.

from milo.

I'm implementing this idea on UaTcpStackClientConfig and OpcUaClientConfig.

edit: and the server versions... even though it's less likely to be needed.

from milo.

Actually I just did it for the server config because I needed them most :-)

from milo.

So I will stick with my local changes and wait for your fix! Thanks!!

Just to let you know what I did. I created two additional constructors, beside the default one. Taking in "Config" and "ConfigBuilder" each. The "ConfigBuilder" just calls "this ( other.build() )", which may not be that performant, but this should not be called that often either.

But that allows one to clone the builder and also create a mutable version from an existing configuration again.

True, every type used by the configuration, should be immutable as well.

from milo.

So I've done half the work... added copy() methods to the client config objects. It's somewhat tedious and boring, especially the tests, so I'm going to take a break and implement the server ones later... 😝

from milo.

Just missing tests for the server config objects now.

from milo.