additional.bundles dependencies are not properly resolved about tycho HOT 18 CLOSED

Thanks for the example, I'll try to take a look at this. Can you verify that removing the additional bundle from the build.properties makes the build succeed?

from tycho.

Can you verify that removing the additional bundle from the build.properties makes the build succeed?

yes this works

so it looks like tycho now seeks for upstream add. bundles to be present in downstream plugins, whilst in pde they are not, they are available in the plugin specifiying the add. bundles only.

from tycho.

so it looks like tycho now seeks for upstream add. bundles to be present in downstream plugins, whilst in p2 they are not, they are available in the plugin specifiying the add. bundles only.

Can you elaborate a bit more here? I must confess I'm not completely sure what you suspect to be the problem here.

from tycho.

pde:
mydsl has add. bundles org.eclipse.xtext.xtext.generator so i can use stuff from it like XtextGenerator class.
in myldsl.ide which has a dependency to mydsl i cannot use stuff from org.eclipse.xtext.xtext.generator
but why does tycho need it then

from tycho.

Tycho resolves the complete chain of transitive dependencies.

from tycho.

then the question would be: why can mydsl find org.eclipse.xtext.xtext.generator if it is resolved itself,
but cannot find it (org.eclipse.xtext.xtext.generator) if it (mydsl) is resovled as dependency of mydsl.ide

so when i restrict the build to

	<modules>
		<module>org.xtext.example.mydsl</module>
		<module>org.xtext.example.mydsl.target</module>
	</modules>

it is green

from tycho.

I don't know yet :-)

Possible reasons include:

• Target platform is different for both projects
• A bug in Tycho
• A bug in P2
• Something is restricting the scope (e.g. platform filters)
• ...

from tycho.

I have checked out your example. The build complains about

"org.xtext.example.mydsl" is missing it is not part of the target nor part of the reactor build.

from tycho.

but why

https://github.com/cdietrich/tych24ddBundlesBug/blob/7e0dbd51eed5802857b45b4db499041457c4eb5c/pom.xml#L25

and why could it be resolved 50 lines before

[INFO] Computing target platform for MavenProject: org.xtext.example.mydsl:org.xtext.example.mydsl:1.0.0-SNAPSHOT @ /Users/cdietrich/eclipse-workspaces/es2103/org.xtext.example.mydsl.parent/org.xtext.example.mydsl/pom.xml
[INFO] Resolving dependencies of MavenProject: org.xtext.example.mydsl:org.xtext.example.mydsl:1.0.0-SNAPSHOT @ /Users/cdietrich/eclipse-workspaces/es2103/org.xtext.example.mydsl.parent/org.xtext.example.mydsl/pom.xml
[INFO] Resolving class path of MavenProject: org.xtext.example.mydsl:org.xtext.example.mydsl:1.0.0-SNAPSHOT @ /Users/cdietrich/eclipse-workspaces/es2103/org.xtext.example.mydsl.parent/org.xtext.example.mydsl/pom.xml
[INFO] Fetching 202103171000&countryCode=de&timeZone=1&format=xml from http://www.eclipse.org/downloads/download.php?format=xml&file=/releases/2021-03/
...

from tycho.

Good question :-)

While implementing this feature I had the problem that the requirement was there but the claspathresolver has thrown it away, but here it seems missing in the first place. I need to further debug this.

from tycho.

I think I found the issue, if the bundles uses requirebundle AND additional bundles then only the req. ones are used.

from tycho.

@cdietrich can you try with a local build version of https://github.com/laeubi/tycho/tree/issue_23 if that fixes your issue?

from tycho.

@laeubi nice, my demo project seems to work, so do xtext-eclipse and xtext-xtend

from tycho.

Thanks for verification!

from tycho.

@laeubi I think this is worthwhile to be mentioned in the release notes

from tycho.

#157 (comment)

from tycho.

@cdietrich 👍 @LorenzoBettini I did not think that this feature is of much interest to be noted in the release notes :-)

from tycho.

@laeubi IMHO it definitely is :)
I mean it's something that it was meant to work but it didn't

from tycho.