Giter Club home page Giter Club logo

Comments (13)

koegel avatar koegel commented on August 10, 2024

@jfaltermeier What is your take on this?

from theia-blueprint.

marcdumais-work avatar marcdumais-work commented on August 10, 2024

electron-app: Rename to blueprint-app?

this is the only one I am not sure. If we might offer a packaged browser application from this repo in the future, we can consider keeping the name as-is, and adding a browser-app for the new one. An other option is to be a bit more verbose: blueprint-electron-app and blueprint-browser-app.

from theia-blueprint.

jfaltermeier avatar jfaltermeier commented on August 10, 2024

@jfaltermeier What is your take on this?

Sounds good.
Besides the already mentioned places I don't see any other oversights atm.

from theia-blueprint.

lucas-koehler avatar lucas-koehler commented on August 10, 2024

I like the suggested names. With the main value of this repository being the packaging and updating of the app, which are both electron specific, I think we can assume for now that there won't be a browser app. Or if there ever is, I think we can rename it then? What do you think @marcdumais-work ?

In any case, we need to make sure to update the documentation accordingly when we do the renames.

from theia-blueprint.

koegel avatar koegel commented on August 10, 2024

I like the suggested names. With the main value of this repository being the packaging and updating of the app, which are both electron specific, I think we can assume for now that there won't be a browser app. Or if there ever is, I think we can rename it then? What do you think @marcdumais-work ?

In any case, we need to make sure to update the documentation accordingly when we do the renames.

Which suggested names do you refer to @lucas-koehler ?

from theia-blueprint.

koegel avatar koegel commented on August 10, 2024

electron-app: Rename to blueprint-app?

this is the only one I am not sure. If we might offer a packaged browser application from this repo in the future, we can consider keeping the name as-is, and adding a browser-app for the new one. An other option is to be a bit more verbose: blueprint-electron-app and blueprint-browser-app.

Good points, now I am even more undecided :)

from theia-blueprint.

lucas-koehler avatar lucas-koehler commented on August 10, 2024

I like the suggested names. With the main value of this repository being the packaging and updating of the app, which are both electron specific, I think we can assume for now that there won't be a browser app. Or if there ever is, I think we can rename it then? What do you think @marcdumais-work ?
In any case, we need to make sure to update the documentation accordingly when we do the renames.

Which suggested names do you refer to @lucas-koehler ?

I'm referring to the folder names because they are used in the documentation to point users to files that they might want to customize.

from theia-blueprint.

koegel avatar koegel commented on August 10, 2024

I like the suggested names. With the main value of this repository being the packaging and updating of the app, which are both electron specific, I think we can assume for now that there won't be a browser app. Or if there ever is, I think we can rename it then? What do you think @marcdumais-work ?
In any case, we need to make sure to update the documentation accordingly when we do the renames.

Which suggested names do you refer to @lucas-koehler ?

I'm referring to the folder names because they are used in the documentation to point users to files that they might want to customize.

I know :). But which of the suggested names do you like?

from theia-blueprint.

lucas-koehler avatar lucas-koehler commented on August 10, 2024

I see :)
I like blueprint-app for the product package (currently in folder electron-app) and blueprint-updater for the extension.

I'm also not opposed to the extensive names suggested by @marcdumais-work but do not think they are necessary. Thus, I would rather rename in case this ever comes relevant, which we don't know yet.

from theia-blueprint.

koegel avatar koegel commented on August 10, 2024

OK, clarified :). I would say we go with the names I proposed then.

from theia-blueprint.

koegel avatar koegel commented on August 10, 2024

@jfaltermeier Can you please take care of the ticket

from theia-blueprint.

koegel avatar koegel commented on August 10, 2024

Main remaining problem is the userhome default folder is still .theia.

from theia-blueprint.

marcdumais-work avatar marcdumais-work commented on August 10, 2024

Main remaining problem is the userhome default folder is still .theia.

I think we can contribute an incremental improvement, that permits to override this with a static string e.g. a product name. In our case the folder could be named .blueprint.

It will be helpful for ourselves to do so, because right now the Blueprint config folder is shared with that of vanilla Theia applications, including our own example application. No good can come of this :)

cc: @vince-fugnitto

from theia-blueprint.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.