Comments (5)
tjwatson
commented on June 28, 2024
I don't see a way to tell moditect to set the module attribute module_version_index to anything specific. It appears to use the pom.xml version. Our build always uses pom versions with SNAPSHOT and then it fills in the qualifier for the bundle manifest version. But we don't do anything with the maven version. Then when they go to publish the artifact to maven central they drop the SNAPSHOT from the maven version.
While this is annoying, I wonder what practical issues it has because there is no way to require a specific version of a Java module.
from equinox.
laeubi
commented on June 28, 2024
Tycho has a new feature to automatically match the pom-version with the manifest version see: https://github.com/eclipse/tycho/blob/master/RELEASE_NOTES.md#enhanced-support-for-maven-ci-friendly-versions
from equinox.
fipro78
commented on June 28, 2024
I don't know if this is really an issue or if this causes problems. I just noticed that inconsistency when looking into another issue and I was wondering why org.eclipse.osgi is a SNAPSHOT although I downloaded the release version. Probably more a user confusion issue rather than a technical one.
from equinox.
stbischof
commented on June 28, 2024
fyi:
i let bnd generate the module-info.class automatically. The result is.
not really related to this issue but if the discussion goes more in the direction of "how to generate the file" this would also be a way
open module org.eclipse.osgi {
requires j9stubs-j9stubs;
requires java.base;
requires java.management;
requires java.xml;
requires jdk.unsupported;
exports org.eclipse.equinox.log;
exports org.eclipse.osgi.framework.console;
exports org.eclipse.osgi.framework.eventmgr;
exports org.eclipse.osgi.framework.log;
exports org.eclipse.osgi.report.resolution;
exports org.eclipse.osgi.service.datalocation;
exports org.eclipse.osgi.service.debug;
exports org.eclipse.osgi.service.environment;
exports org.eclipse.osgi.service.localization;
exports org.eclipse.osgi.service.runnable;
exports org.eclipse.osgi.service.urlconversion;
exports org.eclipse.osgi.storagemanager;
exports org.eclipse.osgi.util;
exports org.osgi.dto;
exports org.osgi.framework.connect;
exports org.osgi.framework.dto;
exports org.osgi.framework.hooks.bundle;
exports org.osgi.framework.hooks.resolver;
exports org.osgi.framework.hooks.service;
exports org.osgi.framework.hooks.weaving;
exports org.osgi.framework.launch;
exports org.osgi.framework.namespace;
exports org.osgi.framework.startlevel.dto;
exports org.osgi.framework.startlevel;
exports org.osgi.framework.wiring.dto;
exports org.osgi.framework.wiring;
exports org.osgi.framework;
exports org.osgi.resource.dto;
exports org.osgi.resource;
exports org.osgi.service.condition;
exports org.osgi.service.condpermadmin;
exports org.osgi.service.log.admin;
exports org.osgi.service.log;
exports org.osgi.service.packageadmin;
exports org.osgi.service.permissionadmin;
exports org.osgi.service.resolver;
exports org.osgi.service.startlevel;
exports org.osgi.service.url;
exports org.osgi.util.tracker;
exports org.eclipse.osgi.internal.debug;
exports org.eclipse.osgi.internal.framework;
exports org.eclipse.osgi.internal.hookregistry;
exports org.eclipse.osgi.internal.loader;
exports org.eclipse.osgi.internal.loader.buddy;
exports org.eclipse.osgi.internal.loader.classpath;
exports org.eclipse.osgi.internal.loader.sources;
exports org.eclipse.osgi.internal.location;
exports org.eclipse.osgi.internal.provisional.service.security;
exports org.eclipse.osgi.internal.provisional.verifier;
exports org.eclipse.osgi.internal.service.security;
exports org.eclipse.osgi.internal.serviceregistry;
exports org.eclipse.osgi.internal.signedcontent;
exports org.eclipse.osgi.internal.url;
exports org.eclipse.osgi.internal.messages;
exports org.eclipse.osgi.framework.internal.reliablefile;
exports org.eclipse.core.runtime.adaptor;
exports org.eclipse.core.runtime.internal.adaptor;
exports org.eclipse.osgi.container;
exports org.eclipse.osgi.container.builders;
exports org.eclipse.osgi.container.namespaces;
exports org.eclipse.osgi.framework.util;
exports org.eclipse.osgi.launch;
exports org.eclipse.osgi.service.pluginconversion;
exports org.eclipse.osgi.service.resolver;
exports org.eclipse.osgi.service.security;
exports org.eclipse.osgi.signedcontent;
exports org.eclipse.osgi.storage;
exports org.eclipse.osgi.storage.bundlefile;
exports org.eclipse.osgi.storage.url;
exports org.osgi.service.serviceloader;
provides org.osgi.framework.connect.ConnectFrameworkFactory with org.eclipse.osgi.launch.EquinoxFactory;
provides org.osgi.framework.launch.FrameworkFactory with org.eclipse.osgi.launch.EquinoxFactory;
}
from equinox.
tjwatson
commented on June 28, 2024
Now that we are moving to use BND to generate the module-info class, we have moved to striping off the qualifier from the module-info version (see #53). I'm going to close this issue because it was about the incorrect version being set with our usage of modetect. There is still some work that needs to be done to make sure the BND production of module-info is correct #27.
from equinox.
Related Issues (20)
- SecurityException in XMLParsingServiceFactory.getService() / lsp4e HOT 5
- LinkageError error with multiple Guava versions and Require-Bundle usage HOT 17
- Secure Storage does not work on Kubuntu 22.04 HOT 1
- Remove include of org.apache.sshd.osgi from the org.eclipse.equinox.core.sdk feature
- [launcher] If used with read-only location, changes to eclipse.ini are ignored HOT 1
- dev.properties provided extra classpath items are invisible to HOT 9
- Deprecated SubProgressMonitor is a mess HOT 1
- git status / git rebase broken on master HOT 1
- Path with Array Overhead HOT 11
- Use the official org.osgi.service.http jar for the http-service packages
- org.osgi.test.cases.framework.junit.hooks.resolver.ResolverHookTests#testBeginTriggers fails HOT 3
- Some cm coordinator testcases fail HOT 1
- Device Access service seem to be not compliant HOT 1
- Add an option to instruct equinox to clean the resolver state HOT 18
- BasicLocationTests#testCreateLocation04() fails silently
- PreferenceService#setDefaultLookupOrder() throws wrong exception
- Eclipse build process throws some warnings in Mac HOT 2
- Switch to macOS sdk version 11 HOT 10
- org.eclipse.equinox.http.service.api missing? HOT 2
- sun.misc.Unsafe will be deprecated with Java 22 HOT 1
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from equinox.