Giter Club home page Giter Club logo

Comments (4)

echasnovski avatar echasnovski commented on August 11, 2024

Thanks for the suggestion!

The "argument" and "function_call" textobjects are exposed in gen_spec because they might be configured to use some different hyper parameters.

Currently I don't think exposing the whole 'builtin_textobjects' is a good idea from maintenance perspective while bringing not huge amount of dividends (setting them up explicitly still works). But I'll think about it.

from mini.nvim.

echasnovski avatar echasnovski commented on August 11, 2024

Sorry, I don't think it is too much for users to have explicit definitions for textobjects that they want to use. And as already was said, "argument" and "function_call" may need configuration so having them in gen_spec makes sense.

Closing as not planned.

from mini.nvim.

IndianBoy42 avatar IndianBoy42 commented on August 11, 2024

That's disappointing to hear, maybe i lack perspective but I didn't think that there would be such a maintenance burden from exposing whats already implemented. I just want to use the existing builtin textobjects with a different key; now I have to repeat the esoteric definitions and lose out on updates unless I manually check whether they have changed.

from mini.nvim.

echasnovski avatar echasnovski commented on August 11, 2024

... but I didn't think that there would be such a maintenance burden from exposing whats already implemented.

It is implemented as an internal helper right now which means that it is free to be transformed in any way that might be necessary. Exporting it makes it harder to do.

Plus documenting and testing all of those 15 extra specifications takes space and effort.

Plus if this is done in 'mini.ai', then it is reasonable to be done in 'mini.surround', which adds 13 more surrounding specifications to export, document, and test.

As both 'mini.ai' and 'mini.surround' are already quite big and benefits are not huge, I'd better not export them.

from mini.nvim.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.