Giter Club home page Giter Club logo

Comments (8)

6H075T2 avatar 6H075T2 commented on September 15, 2024 1

@echasnovski, I never thought you'll give my request some attention since it's I've considered it silly because I don't think anyone even want this feature and possibly even go againts your project principle, I really appreciate your effort to make this possible. <3

Here's what it looks now.
image

I'm looking forward to your mini.statuscolumn plugin 😊

from mini.nvim.

echasnovski avatar echasnovski commented on September 15, 2024

If possible, it would be something along the lines of customizing window example, but with MiniFilesWindowUpdate event (because title can change after window is opened).

However, quick tests showed that title is somewhat special, as it indeed updates when navigating horizontally. I am afraid, declaring title "special" and not designed to be customized is a reasonable approach here.

from mini.nvim.

6H075T2 avatar 6H075T2 commented on September 15, 2024

@echasnovski, Thanks for atleast trying to help me I just want to make the title/path to be more emphasized and make it look appealing to me. :) btw I really loved your plugins but is it possible to add a "padding" so that the Icons itself is not really close to the border?

from mini.nvim.

echasnovski avatar echasnovski commented on September 15, 2024

Icons are the result of applying default_prefix() which is used by default as config.content.prefix.

Here is an example of how to override it so that there is an extra space before an icon:

local prefix = function(fs_entry)
  local icon, hl = MiniFiles.default_prefix(fs_entry)
  return ' ' .. icon, hl
end
require('mini.files').setup({ content = { prefix = prefix } })

from mini.nvim.

6H075T2 avatar 6H075T2 commented on September 15, 2024

@echasnovski, Thanks for very fast response now it works as I intended and looks nice. But my current concern is about the link you've provided in customizing window example why is it that the "Title" property when assigned by a function that returns the current working directory as a title doesn't automatically add spaces like the a normal title would do.

from mini.nvim.

echasnovski avatar echasnovski commented on September 15, 2024

But my current concern is about the link you've provided in customizing window example why is it that the "Title" property when assigned by a function that returns the current working directory as a title doesn't automatically add spaces like the a normal title would do.

I don't really understand the question. By default titles in floating windows are not padded with spaces.

The reason customization doesn't apply for titles is because they are a bit special as described in the original response:

However, quick tests showed that title is somewhat special, as it indeed updates when navigating horizontally. I am afraid, declaring title "special" and not designed to be customized is a reasonable approach here.

from mini.nvim.

echasnovski avatar echasnovski commented on September 15, 2024

@6H075T2, after some recent changes, I think adding space padding to title now should be possible. You can follow the newly added example (without the config.height part) and it should work.

This use case even has a dedicated test in the hope that it will keep working.

I changed my mind about this issue because height also could not be customized (see #1140). As the root cause has revealed to be the same (intentional blocking of too frequent MiniFilesWindowUpdate event triggering), it seems to be more reasonable to change the balance here (from preferring performance to preferring actual customization with heavy warning that it is triggered frequently.

from mini.nvim.

echasnovski avatar echasnovski commented on September 15, 2024

@echasnovski, I never thought you'll give my request some attention since it's I've considered it silly because I don't think anyone even want this feature and possibly even go againts your project principle, I really appreciate your effort to make this possible. <3

To be perfectly honest, I indeed did not intend to account for this (because they indeed are special). It was somewhat of a coincidence that the key problem that blocked this also happened to block other customizations. That felt a bit too much, so decided to address it.

Besides, I briefly tried it, and can confirm that it indeed looks beautiful :)

I'm looking forward to your mini.statuscolumn plugin 😊

Me too. However, quick tests couple of weeks ago showed that it might be reasonable to wait until 0.11 release, because current Nightly has some significant quality of life improvements in 'statuscolumn'. We'll see.

from mini.nvim.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.