Comments (15)
Ok, I think we can reduce code complexity and should put the formatting in .colour_column_if()
. Now we have to get rid of NA
where it makes no sense.
from report.
from report.
I digged a bit into the code, and this one is tricky... we need to use format()
on the complete column, e.g. in .colour_column_if()
. But once it's a string, we can't check for the negative / positive sign... ?!?
from report.
Yes, I tried with some regex detection (if the stripped characters began with the "-" string), without success...
We might need to imagine another way of integrating the colouring, the formatting and the to-string conversion than my clunky proposal
from report.
Moreover, the format has to be used on the striped columns (without the colour codes), otherwise, the columns are too large (as the colour codes disappear)... So yea very tricky, puzzling and challenging haha... and worth trouble (even now with the uneven columns, I find the colouring of the coefs and such super cool 😄)
from report.
This can be relevant for future vignette / readme improvements: https://twitter.com/BrodieGaslam/status/1029059002225721344
from report.
I would say that column with numers should be right-aligned, while "string" columns (with values that are non-numeric from the user's perspective) should be left-aligned... Isn't this a common table convention?
from report.
Table printing no longer works for model-objects when digits are specified. Thus, we need some extra handling here. I tried to solve this using an additional class attribute. We should think about how to solve this issue, respectively if my suggestion is ok and not too sloppy.
from report.
It looks great 🎊 🎉 ! Brilliant implementation, thanks :)
from report.
It seems that bold slightly enlarges the column, resulting in a minor misalignment toward the end... but that's details ^^
from report.
Damn... ;-)
I have a fix in mind, will try this evening. We could, for the p-value column, replace all empty values with as many whitespaces as "column-width" (nchar()
) and sourround the whitespaces with bold as well... Or we switch to a colour. But misalignment doesn't look that nice. :-)
from report.
Can you check if my workaround works for you? I don't have this alignment issue.
from report.
Seems like it's still there... are you using R studio also?
from report.
Yes, I'm using RStudio (both latest stable and current preview) on Windows 10 (light theme). Strange, but then let's format p-values in colour, not bold.
from report.
Strange indeed... maybe has something to do with the font used?
Will change back to yellow then (or maybe orange if yellow is too hard to read on a light theme?)
from report.
Related Issues (20)
- Report text duplicated many times for brms model using in a tidymodels workflow
- Fix failing snapshots1: `report.htest-chi2` HOT 3
- Fix failing snapshots2: `report.brms`
- problems using group_by with cor.test report HOT 1
- ANOVA report missing 2nd degrees of freedom
- Missing citation for Allie Brosh's "All the Things" image HOT 2
- [Feature request] Support output of `test_predictions` from `ggeffects` HOT 3
- Can not report models/objects derived from function in pysch package
- Fix contrast errors coming from a customization that only the report website template is using HOT 2
- My hub
- t.test sign interpretation HOT 1
- Gender vs Sex mismatch in report_participants HOT 1
- Test failing on CRAN HOT 1
- Change how unspecified `...` arguments are passed to other functions HOT 1
- Fix all new failing checks HOT 1
- Fix `check-test-warnings` workflow: "Global state has changed" in `test-report.brmsfit` HOT 2
- report.loo_compare docs example broken HOT 3
- report() assigning effect size to intercept in model HOT 4
- report() not outputting denominator degrees of freedom HOT 3
- Fail to compute report for Kruskal test in some cases HOT 1
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from report.