Giter Club home page Giter Club logo

Comments (4)

gdlcf88 avatar gdlcf88 commented on June 30, 2024

totalOrderLineActualTotalPrice是由orderLinesInScope产生，后者只会包含符合条件的订单，如果金额不满足要求，不会在此范围内。

PerMeet 的注释错了，是应该改成 900，你可以提交一个 PR 纠正它吗？

from eshop.

gdlcf88 avatar gdlcf88 commented on June 30, 2024

Sorry，纠正，不是在orderLinesInScope 中筛选订单项，而是在订单产生时已经筛选过了：

EShop/modules/EasyAbp.EShop.Orders/src/EasyAbp.EShop.Orders.Domain/EasyAbp/EShop/Orders/Orders/NewOrderGenerator.cs

Line 112 in a52aa4c

var distributions = await _orderDiscountResolver.ResolveAsync(order, productDict);

from eshop.

zhangzw218 avatar zhangzw218 commented on June 30, 2024

我在NewOrerGenerator中，没找到筛选订单的处理。

OrdersAppServiceTests.cs中写了个测试
[InlineData(5, 2.3, 4, 0, CouponType.Normal)]
这个不满足条件，依然触发了满减。
不确定是否我测试写错了，能否帮忙看下？
https://github.com/zhangzw218/EShop/tree/zzw/20240619_4.2.0

https://github.com/zhangzw218/EShop/blob/zzw/20240619_4.2.0/plugins/Coupons/test/EasyAbp.EShop.Orders.Plugins.Coupons.Tests/Orders/OrdersAppServiceTests.cs

from eshop.

gdlcf88 avatar gdlcf88 commented on June 30, 2024

这是一个 Bug，在 #280 中修复，如果可以把你的 UT 提交到本仓库，会很有帮助。（但是请全英文化，以便长期维护）

from eshop.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.