Add scalar-only overloads for `ekat::max`, `ekat::min`, `ekat::abs` about ekat HOT 8 CLOSED

Okay, that's a fair point. I don't particularly sympathize with anyone who gets all sorts of errors when they use using namespace std, but we probably don't want to contribute any more to the confusion.

from ekat.

If you issue, say, using std::min in your app code, then I believe that min(a,b) should work, no?

from ekat.

Actually, we are already providing min/max in ekat_math_utils.hpp. Does your code compile if you include that header? I guess we could add a similar one for abs in that file...

from ekat.

The ones in ekat_math_utils.hpp seem to be under the ekat::impl namespace, which suggests "no touchy!". But yeah, we could just use these. Is there any reason to stash them in the impl namespace?

from ekat.

Ah, yeah, you're right. I guess we put them there to not explicitly pollute ekat's namespace, in case the user does using namespace ekat, but doesn't want these overloads.

from ekat.

It seems like a user who includes that header might not mind having those functions available in the ekat namespace. Otherwise they get only theis_invalid and transpose functions.

from ekat.

I think that names like max or min are so common that it would be somewhat dangerous to inject them into ekat's namespace. I can see apps doing using namespace ekat, but if they also are doing (ugh) using namespace std (or any other library namespace that declares max/min), then there might be compile/link errors (or worse, runtime ones).

I'm ok moving unambiguous names outside of the impl namespace, but max/min (and even isfinite) are shared with the std lib, which imho is too dangerous to do it by default. If someone is interested in getting those functions, they can do using namespace ekat::impl. It's a one line price to pay, but it gives more security long term.

from ekat.

I agree, using the std namespace is not a great practice. But on the other hand, there are likely other libs that may overload such common name functions...

from ekat.