EkatCreateUnitTest still expects the test sources, even if TEST_EXE is provided about ekat HOT 3 CLOSED

@bartgol , I noticed this when I was testing this feature. The user just needs to pass an empty string for those, like I did here:

  CreateUnitTest(resource_spread_rank "" ""
    TEST_EXE resource_spread_thread

Not super elegant, but at least it keeps us from needing multiple macros. One thing we could do is raise an error if the user provides a TEST_EXE but also tries to provide sources or test libs.

We could bite the bullet and go with multiple macros too.

from ekat.

Imho, passing empty args just to fit into the existing macro is not the right choice. You're hijacking the existing framework to do something different. For a developer that has never seen it, it might be confusing.

I think I will write the 3 macro solution, which is fully bwd compatible, and (imho) more self-explanatory for the new use case. Furthermore, since the last macro (the one that we currently use) would be impl-ed in terms of the previous two, I think the amount of actual code (adding up the macros bodies) would remain unchanged. It would simply be broken into 2 macros.

from ekat.

Fixed by #166

from ekat.