Giter Club home page Giter Club logo

Comments (4)

bartgol avatar bartgol commented on August 12, 2024 1

I agree. I'm not sure why we (I?) split the cmake flow for serial/parallel tests.

In SCREAM we have the cmake cache vars SCREAM_MPIRUN_EXE, SCREAM_MPIRUN_EXTRA_ARGS, and SCREAM_MPI_NP_FLAG, which can be used to tune the mpiexec invoke line (e.g., SCREAM_MPIRUN_EXE=srun for slurm).

from ekat.

jeff-cohere avatar jeff-cohere commented on August 12, 2024 1

Sure, I'll add that stuff.

from ekat.

jeff-cohere avatar jeff-cohere commented on August 12, 2024

That's a good point. I think we can live with setting the right MPIRUN command manually. So maybe this is just about removing the nproc>1 guards.

I can take care of this if we think that's true.

from ekat.

bartgol avatar bartgol commented on August 12, 2024

EkatCreateUnitTest already has optional args for MPI_EXEC, MPI_EXTRA_ARGS, MPI_NP_FLAG. We do not have them in Ekat itself (so ekat internal testing does not allow to tweak them), but external apps can already achieve the result (except the nproc>1 guard, as you mentioned).

If you go ahead and do the nproc>1 guard mod, would you mind adding the cache vars EKAT_TEST_MPIRUN_EXE, EKAT_TEST_MPI_EXTRA_ARGS, and EKAT_TEST_MPIRUN_NP_FLAG in the tests/CMakeLists.txt file as well? They can of course default to the usual suspects: "mpirun", "", "-np" (though the extra args might be nice to have it defaulting to "--bind-to core", since I think that's usually what one needs).

from ekat.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.